-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable UAMI auth for Data Factory Sql Server connector #29205
Enable UAMI auth for Data Factory Sql Server connector #29205
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Hi @seanwang051, this service has enabled ShiftLeft Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it is intentional or reject it if it is not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Swagger Validation Report
|
Compared specs (v0.10.9) | new version | base version |
---|---|---|
LinkedService.json | 2018-06-01(f37d420) | 2018-06-01(main) |
LinkedService.json | 2020-12-01(f37d420) | 2020-12-01(main) |
Rule | Message |
---|---|
1020 - AddedEnumValue |
The new version is adding enum value(s) 'UserAssignedManagedIdentity' from the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L456:9 Old: stable/2018-06-01/entityTypes/LinkedService.json#L456:9 |
1020 - AddedEnumValue |
The new version is adding enum value(s) 'UserAssignedManagedIdentity' from the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L408:9 Old: stable/2020-12-01/entityTypes/LinkedService.json#L408:9 |
1045 - AddedOptionalProperty |
The new version has a new optional property 'credential' that was not found in the old version. New: stable/2018-06-01/entityTypes/LinkedService.json#L450:7 Old: stable/2018-06-01/entityTypes/LinkedService.json#L450:7 |
1045 - AddedOptionalProperty |
The new version has a new optional property 'credential' that was not found in the old version. New: stable/2020-12-01/entityTypes/LinkedService.json#L403:7 Old: stable/2020-12-01/entityTypes/LinkedService.json#L403:7 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/pr RequestMerge |
* update * remove SAMI --------- Co-authored-by: seanwang051 <xiaojwan@microsoft.com> Co-authored-by: Razvan Badea <156206747+razvanbadea-msft@users.noreply.github.com>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.