Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Indexer Private Endpoint Onboarding #29266

Merged
merged 12 commits into from
Jun 12, 2024

Conversation

tshaiman
Copy link
Contributor

@tshaiman tshaiman commented May 29, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

This PR onboards Azure Video Indexer to have Private Endpoint support for our customers. It has several new APIs that were added following our integration with the RPaaS team. The changes were on testing with a preview version from `azure-rest-api-specs-pr` repo for few months

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented May 29, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented May 29, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 18 Errors, 24 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
vi.json 2024-06-01-preview(63c96c2) 2024-01-01(main)
vi.json 2024-06-01-preview(63c96c2) 2024-04-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1023 - TypeFormatChanged The new version has a different format 'uri' than the previous one ''.
New: common-types/resource-management/v5/types.json#L413:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L919:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L88:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L88:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L133:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L133:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L172:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L172:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L209:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L209:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L250:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L250:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L302:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L302:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L366:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L366:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L431:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L431:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L488:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L488:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L632:5
Old: common-types/resource-management/v2/types.json#L649:5
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: common-types/resource-management/v5/types.json#L384:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L858:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: common-types/resource-management/v5/types.json#L370:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L869:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L344:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L864:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L307:9
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L931:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L282:11
Old: Microsoft.VideoIndexer/stable/2024-01-01/vi.json#L954:11


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L344:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L938:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L307:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L1005:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L282:11
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L1028:11
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uri' than the previous one ''.
New: common-types/resource-management/v5/types.json#L413:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L993:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L88:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L88:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L133:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L133:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L172:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L172:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L209:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L209:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L250:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L250:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L302:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L302:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L366:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L366:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L431:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L431:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L488:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L488:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L632:5
Old: common-types/resource-management/v2/types.json#L649:5
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v2/types.json#L14:9
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: common-types/resource-management/v5/types.json#L384:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L932:9
⚠️ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: common-types/resource-management/v5/types.json#L370:9
Old: Microsoft.VideoIndexer/preview/2024-04-01-preview/vi.json#L943:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 3 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-06-01-preview package-2024-06-01-preview(63c96c2) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of privatelinks.json.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L552
⚠️ ParameterDescription Parameter should have a description.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L638
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of privatelinks.json.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L761


The following errors/warnings exist before current PR submission:

Rule Message
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L267
RepeatedPathInfo The 'accountName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L309
DeleteResponseCodes An async DELETE operation must set ''x-ms-long-running-operation' : true'.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L359
LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true. GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be defined
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L365
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L384
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L409
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generaterestrictedvieweraccesstoken' in:'Generate_RestrictedViewerAccessToken'. Consider updating the operationId
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L475
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json#L1281
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 29, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from db0511241fe504b936ec111de3b8029722bd646a. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-videoindexer [Preview SDK Changes]
    • azure_mgmt_videoindexer-1.0.0b1-py3-none-any.whl
    • azure-mgmt-videoindexer-1.0.0b1.zip
    info	[Changelog]   - Initial Release
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from db0511241fe504b936ec111de3b8029722bd646a. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-vi [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-vi-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-vi-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from db0511241fe504b936ec111de3b8029722bd646a. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/videoindexer/armvideoindexer [Preview SDK Changes]
    info	[Changelog] This is a new package
    info	[Changelog]
️❌ azure-sdk-for-js failed [Detail]
  • Failed in generating from db0511241fe504b936ec111de3b8029722bd646a. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] Error:
    cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for readme file: "specification/vi/resource-manager/readme.md":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t vi
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t vi
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:87:46
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
    cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
  • info	[Changelog]
    error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from db0511241fe504b936ec111de3b8029722bd646a. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from db0511241fe504b936ec111de3b8029722bd646a. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.vi.DefaultTag [Preview SDK Changes]
    • Az.Vi.0.1.0.nupkg
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented May 29, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label May 31, 2024
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label May 31, 2024
@tshaiman
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels May 31, 2024
@tshaiman
Copy link
Contributor Author

tshaiman commented Jun 5, 2024

@TimLovellSmith @mikekistler The PR Is ready for merge , we only fail on a step that is not related to us

SDK azure-resource-manager-schemas failed

it has many javascript error unrelated to us . who is this script owner ?
can you approve the PR ?

@mikekistler
Copy link
Member

You can get help on the JavaScript error from the Service API Toolset teams channel. Ping me on Teams if you need a link to that.

@ms-bogdan-rotaru
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ms-bogdan-rotaru
Copy link

Which is the suppression which triggered the "SuppressionReviewRequired" label?

@tshaiman
Copy link
Contributor Author

@ms-bogdan-rotaru I have no idea !

@tshaiman
Copy link
Contributor Author

@ms-bogdan-rotaru maybe the SDK-resouce-manager-schemas ?

@ms-bogdan-rotaru ms-bogdan-rotaru added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jun 10, 2024
@ms-bogdan-rotaru
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ms-bogdan-rotaru ms-bogdan-rotaru removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 10, 2024
@ms-bogdan-rotaru
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@konrad-jamrozik konrad-jamrozik added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 10, 2024
@ms-bogdan-rotaru ms-bogdan-rotaru merged commit 8e8e199 into main Jun 12, 2024
29 of 32 checks passed
@ms-bogdan-rotaru ms-bogdan-rotaru deleted the feature/tshaiman/vi-private-endpoint-onboarding branch June 12, 2024 08:05
HuShaoRu pushed a commit to HuShaoRu/azure-rest-api-specs that referenced this pull request Jun 13, 2024
* base commit

* docs

* adding private link support

* examples for private endpoint

* register AllowPublicAccess field for Private Endpoint

* allign common types version

* no default on Patch

* MI

* OperationListResult

* privare link resource pageble

* move to common-types operations

* video-indexer instead analyzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants