-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Indexer Private Endpoint Onboarding #29266
Video Indexer Private Endpoint Onboarding #29266
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
specification/vi/resource-manager/Microsoft.VideoIndexer/preview/2024-06-01-preview/vi.json
Outdated
Show resolved
Hide resolved
@TimLovellSmith @mikekistler The PR Is ready for merge , we only fail on a step that is not related to us
it has many javascript error unrelated to us . who is this script owner ? |
You can get help on the JavaScript error from the Service API Toolset teams channel. Ping me on Teams if you need a link to that. |
...urce-manager/Microsoft.VideoIndexer/preview/2024-06-01-preview/examples/ViAccountDelete.json
Show resolved
Hide resolved
...esource-manager/Microsoft.VideoIndexer/preview/2024-06-01-preview/examples/ViAccountGet.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
Which is the suppression which triggered the "SuppressionReviewRequired" label? |
@ms-bogdan-rotaru I have no idea ! |
@ms-bogdan-rotaru maybe the SDK-resouce-manager-schemas ? |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
* base commit * docs * adding private link support * examples for private endpoint * register AllowPublicAccess field for Private Endpoint * allign common types version * no default on Patch * MI * OperationListResult * privare link resource pageble * move to common-types operations * video-indexer instead analyzer
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
This PR onboards Azure Video Indexer to have Private Endpoint support for our customers. It has several new APIs that were added following our integration with the RPaaS team. The changes were on testing with a preview version from `azure-rest-api-specs-pr` repo for few months
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.