Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply code review #29272

Merged
merged 3 commits into from
May 30, 2024
Merged

apply code review #29272

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6862f71
apply code review
norshtein May 30, 2024
171dfac
remove wireserver description because it's not link local address
norshtein May 30, 2024
80fa3f0
apply code review
norshtein May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ce-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4919,7 +4919,7 @@
},
"PodLinkLocalAccess": {
"type": "string",
"description": "Defines access to special link local addresses (IMDS and wire server) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.",
"description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. If not specified, the default is 'IMDS'.",
norshtein marked this conversation as resolved.
Show resolved Hide resolved
"enum": [
"IMDS",
"None"
Expand All @@ -4930,11 +4930,11 @@
"values": [
{
"value": "IMDS",
"description": "Pods with hostNetwork=false can access IMDS without restriction."
"description": "Pods with hostNetwork=false can access Azure Instance Metadata Service(IMDS) without restriction."
},
{
"value": "None",
"description": "Pods with hostNetwork=false cannot access IMDS and wire server."
"description": "Pods with hostNetwork=false cannot access Azure Instance Metadata Service(IMDS)."
}
]
}
Expand Down Expand Up @@ -5178,7 +5178,7 @@
},
"podLinkLocalAccess": {
"$ref": "#/definitions/PodLinkLocalAccess",
"description": "Defines access to special link local addresses (IMDS and wire server) for pods with hostNetwork=false. if not specified, the default is 'IMDS'."
"description": "Defines access to special link local addresses(Azure Instance Metadata Service, aka IMDS) for pods with hostNetwork=false. if not specified, the default is 'IMDS'."
},
"kubeProxyConfig": {
"type": "object",
Expand Down