Update TypeSpec for DeviceRegistry #29319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
This was referenced Jun 4, 2024
pshao25
reviewed
Jun 4, 2024
pshao25
reviewed
Jun 7, 2024
specification/deviceregistry/DeviceRegistry.Management/tspconfig.yaml
Outdated
Show resolved
Hide resolved
pshao25
reviewed
Jun 7, 2024
specification/deviceregistry/DeviceRegistry.Management/tspconfig.yaml
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Given the current API version is still preview, breaking changes should be allowed for it. |
ArthurMa1978
approved these changes
Jun 11, 2024
tadelesh
approved these changes
Jun 11, 2024
live1206
added
the
BreakingChange-Approved-Benign
pshao25
approved these changes
Jun 11, 2024
AzureRestAPISpecReview
added
WaitForARMFeedback
live1206
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
@live1206, @ArthurMa1978 @pshao25 - Those changes are breaking the swagger validation on our side for the fields moved from |
davidemontanari
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit d1bbbb3.
No, this is not how Azure policy works. You have customers using the preview api-version and breaking those customers is not allowed. Instead, Azure policy is to ship a new api-version and then stop supporting the old api-version after 90 days. Now, customers have 90 days to migrate from the old to the new adopting the breaking changes. |
|
@live1206 you wrote:
But this is not correct: it is not allowed to break a deployed API version, even when in preview, per this doc. There is a minor bug in the tooling in which it should have added Per this Teams post by @davidemontanari looks like merging this PR caused breakage as captured by this Sev 2: Revert PR by @davidemontanari: |
rkmanda
added a commit
that referenced
this pull request
Jun 11, 2024
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Jun 11, 2024
* Update TypeSpec for DeviceRegistry * add client.tsp * fix model validation * fix example * fix example * remove unused csharp option * update client.tsp * fix tsp validation * fix more tsp validation * update csharp option
|
@davidemontanari @JeffreyRichter @konrad-jamrozik @davidemontanari I will try to add a new version for the needed change. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.