Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.SecurityDevOps RP #29326

Merged

Conversation

JohnathonMohr
Copy link
Contributor

@JohnathonMohr JohnathonMohr commented Jun 4, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • The Microsoft.SecurityDevOps resource provider has been fully decommissioned, so this change is to cleanup and remove references to the removed APIs.
    • This RP was replaced by moving the functionality into Microsoft.Security/securityConnectors/devops.
    • API version 2022-09-01-preview (removed in this PR) was replaced with Microsoft.Security API version 2023-09-01-preview.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Swagger Validation Report

️❌BreakingChange: 52 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
securitydevops.json 2022-09-01-preview(bc810d3) 2022-09-01-preview(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L57:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/repos' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L275:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/stats' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L322:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L367:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs/{azureDevOpsOrgName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L414:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs/{azureDevOpsOrgName}/projects' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L594:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs/{azureDevOpsOrgName}/projects/{azureDevOpsProjectName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L644:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs/{azureDevOpsOrgName}/projects/{azureDevOpsProjectName}/repos' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L833:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors/{azureDevOpsConnectorName}/orgs/{azureDevOpsOrgName}/projects/{azureDevOpsProjectName}/repos/{azureDevOpsRepoName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L886:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1090:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1134:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/repos' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1352:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/stats' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1400:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/owners' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1445:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/owners/{gitHubOwnerName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1493:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/owners/{gitHubOwnerName}/repos' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1673:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.SecurityDevOps/gitHubConnectors/{gitHubConnectorName}/owners/{gitHubOwnerName}/repos/{gitHubRepoName}' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1724:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.SecurityDevOps/gitHubConnectors' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1913:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.SecurityDevOps/azureDevOpsConnectors' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1955:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.SecurityDevOps/operations' removed or restructured?
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L1997:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActionableRemediation' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ActionableRemediationState' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AuthorizationInfo' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AutoDiscovery' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureDevOpsConnector' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureDevOpsConnectorProperties' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureDevOpsOrg' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureDevOpsOrgProperties' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AzureDevOpsProject' removed or renamed?
New: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L13:3
Old: Microsoft.SecurityDevOps/preview/2022-09-01-preview/securitydevops.json#L2034:3
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️❌Avocado: 3 Errors, 0 Warnings failed [Detail]
Rule Message
MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: Microsoft.SecurityDevOps/preview/2022-09-01-preview/examples
MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: resource-manager/Microsoft.SecurityDevOps/preview/2022-09-01-preview
MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
folder: bc810d376fdb76daebba6396cb5fc4ecec561aff/specification/securitydevops/resource-manager
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jun 4, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview resource-manager labels Jun 4, 2024
@mikekistler mikekistler added the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Jun 10, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jun 11, 2024
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 11, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 11, 2024
@JohnathonMohr
Copy link
Contributor Author

/pr RequestMerge

@ms-bogdan-rotaru ms-bogdan-rotaru merged commit 259fe9a into Azure:main Jun 12, 2024
30 of 32 checks passed
HuShaoRu pushed a commit to HuShaoRu/azure-rest-api-specs that referenced this pull request Jun 13, 2024
@XiaofeiCao
Copy link
Contributor

@JohnathonMohr May I know why this RP is removed? Is it renamed to or included in another RP?

@JohnathonMohr
Copy link
Contributor Author

JohnathonMohr commented Jun 24, 2024

@JohnathonMohr May I know why this RP is removed? Is it renamed to or included in another RP?

@XiaofeiCao yes, moved to Microsoft.Security. Please see "Purpose of this PR" section in PR description for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants