Network 2018 04 01 #2934

MikhailTryakhov · 2018-04-24T00:33:26Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…into HEAD

MikhailTryakhov · 2018-04-24T00:36:46Z

+@dsgouda

azuresdkciprbot · 2018-04-24T00:41:02Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(4 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T00:41:02Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(77 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-04-24T00:52:26Z

Automation for azure-libraries-for-java

Encountered a Subprocess error: (azure-libraries-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpow57u7c4/rest/specification/network/resource-manager/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpow57u7c4/sdk', '--fluent', '--java', '--multiapi', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (~2.1.32->2.1.49)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Shutting Down
FATAL: java/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.java' terminated.

AutorestCI · 2018-04-24T01:08:10Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpg50o694f/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpg50o694f/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4272/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4272)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.46)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Shutting Down
Shutting Down
FATAL: nodejs/generate - FAILED
FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.
Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.nodejs' terminated.

AutorestCI · 2018-04-24T01:30:41Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8xs_4b0o/rest/specification/network/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp8xs_4b0o/sdk', '--use=@microsoft.azure/autorest.python@~3.0', '--version=preview']
Finished with return code -9
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4275/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4275)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.50)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2018-02"} .

AutorestCI · 2018-04-24T01:46:32Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1687

dsgouda · 2018-04-24T15:29:30Z

...ication/network/resource-manager/Microsoft.Network/stable/2018-02-01/ddosProtectionPlan.json

@@ -258,7 +258,35 @@
  },
  "definitions": {
    "DdosProtectionPlan": {
+      "description": "A DDoS protection plan in a resource group.",


@MikhailTryakhov please undo any changes to the 2018-02-01 directory files.

lmazuel · 2018-04-24T15:49:13Z

...n/network/resource-manager/Microsoft.Network/stable/2018-04-01/applicationSecurityGroup.json

+  "info": {
+    "title": "NetworkManagementClient",
+    "description": "The Microsoft Azure Network management API provides a RESTful set of web services that interact with Microsoft Azure Networks service to manage your network resources. The API has entities that capture the relationship between an end user and the Microsoft Azure Networks service.",
+    "version": "2018-02-01"


Invalid ApiVersion for this folder. Same pattern applies to all files that are currently 2018-02-01 if necessary (don't touch VMSS files)

MikhailTryakhov · 2018-04-24T19:03:40Z

@dsgouda @lmazuel fixed requested changes. please review

azuresdkciprbot · 2018-04-24T19:04:15Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T19:04:15Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(4 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T19:12:44Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-24T19:12:44Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(4 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

dsgouda · 2018-04-24T21:25:46Z

@lmazuel nice catch!
Any other comments I might have missed?

dsgouda

LGTM

dsgouda · 2018-04-24T21:31:19Z

@MikhailTryakhov once @lmazuel approves we're good to merge

MikhailTryakhov · 2018-04-24T22:15:15Z

Thanks @dsgouda. Can we create May branch right after that?
@lmazuel to make review easier. I've changed a version from 2018-02-01 to 2018-04-01 in all files of network branch except VMSS (2 files). Please let me know if there something else to change

lmazuel · 2018-04-25T19:32:26Z

...r/Microsoft.Network/stable/2018-04-01/examples/ApplicationGatewayAvailableSslOptionsGet.json

@@ -0,0 +1,9 @@
+{
+  "parameters": {
+    "api-version": "2018-02-01",


Please update ApiVersion of examples as well

lmazuel

I approve to unlock, since last thing is a detail, but api-version of example needs to be in sync of the Swagger content.

azuresdkciprbot · 2018-04-25T20:21:06Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(108 total)

❌0 new Errors.(4 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-04-25T20:21:06Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️

0 new Warnings.(95 total)

❌0 new Errors.(78 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

murilogiacometti and others added 3 commits April 19, 2018 14:15

Make id readonly by bringing properties from shared resource (#2901)

d969928

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

12f030f

…into HEAD

Added 2018-04-01 folder in the list of stable versions

80d88a7

MikhailTryakhov requested a review from DeepakRajendranMsft as a code owner April 24, 2018 00:33

azuresdkci assigned lmazuel Apr 24, 2018

azuresdkci requested a review from lmazuel April 24, 2018 00:35

MikhailTryakhov added the Network label Apr 24, 2018

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR network/resource-manager] Network 2018 04 01 AutorestCI/azure-libraries-for-java#110

Open

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR network/resource-manager] Network 2018 04 01 Azure/azure-sdk-for-node#2786

Closed

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR network/resource-manager] Network 2018 04 01 Azure/azure-sdk-for-python#2457

Closed

AutorestCI mentioned this pull request Apr 24, 2018

[AutoPR network/resource-manager] Network 2018 04 01 Azure/azure-sdk-for-go#1687

Closed

dsgouda reviewed Apr 24, 2018

View reviewed changes

lmazuel requested changes Apr 24, 2018

View reviewed changes

MikhailTryakhov added 2 commits April 24, 2018 11:58

Reverted April changes in the February branch

a594538

Fixed versions in April folder

1c403f1

dsgouda approved these changes Apr 24, 2018

View reviewed changes

lmazuel reviewed Apr 25, 2018

View reviewed changes

lmazuel approved these changes Apr 25, 2018

View reviewed changes

fixed examples API version

12ad973

dsgouda merged commit 2eb0271 into master Apr 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network 2018 04 01 #2934

Network 2018 04 01 #2934

MikhailTryakhov commented Apr 24, 2018 •

edited by azuresdkci

Loading

MikhailTryakhov commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

dsgouda Apr 24, 2018

lmazuel Apr 24, 2018

MikhailTryakhov commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

dsgouda commented Apr 24, 2018

dsgouda left a comment

dsgouda commented Apr 24, 2018

MikhailTryakhov commented Apr 24, 2018

lmazuel Apr 25, 2018

lmazuel left a comment

azuresdkciprbot commented Apr 25, 2018

azuresdkciprbot commented Apr 25, 2018

Network 2018 04 01 #2934

Network 2018 04 01 #2934

Conversation

MikhailTryakhov commented Apr 24, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

MikhailTryakhov commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-libraries-for-java

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 24, 2018 • edited Loading

Automation for azure-sdk-for-go

dsgouda Apr 24, 2018

Choose a reason for hiding this comment

lmazuel Apr 24, 2018

Choose a reason for hiding this comment

MikhailTryakhov commented Apr 24, 2018

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented Apr 24, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

dsgouda commented Apr 24, 2018

dsgouda left a comment

Choose a reason for hiding this comment

dsgouda commented Apr 24, 2018

MikhailTryakhov commented Apr 24, 2018

lmazuel Apr 25, 2018

Choose a reason for hiding this comment

lmazuel left a comment

Choose a reason for hiding this comment

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented Apr 25, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

MikhailTryakhov commented Apr 24, 2018 •

edited by azuresdkci

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading

AutorestCI commented Apr 24, 2018 •

edited

Loading