-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Modules and Activities Response #2941
Conversation
@vrdmr Please take a look. |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/automation/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/automation/resource-manager/readme.md
|
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmpj5p94k84/rest/specification/automation/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpj5p94k84/sdk', '--nodejs'] AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (~2.1.25->2.1.59)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:946:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:293:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:966:4 ($.definitions.DscNodeUpdateParameters)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1553:4 ($.definitions.DscNodeUpdateParameters)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscCompilationJob.json:546:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNodeConfiguration.json:415:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
- file:///tmp/tmpj5p94k84/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1505:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
Process() cancelled due to exception : Cancellation requested.
Cancellation requested. |
Automation for azure-sdk-for-pythonEncountered a Subprocess error: (azure-sdk-for-python)
Command: ['/usr/local/bin/autorest', '/tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp4m6vp_qv/sdk', '--use=@microsoft.azure/autorest.python@2.1.40', '--version=preview'] AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
Loading AutoRest extension '@microsoft.azure/autorest.python' (2.1.40->2.1.40)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:946:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:293:4 ($.definitions.AgentRegistrationRegenerateKeyParameter)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNode.json:966:4 ($.definitions.DscNodeUpdateParameters)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1553:4 ($.definitions.DscNodeUpdateParameters)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscCompilationJob.json:546:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2018-01-15/dscNodeConfiguration.json:415:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
- file:///tmp/tmp4m6vp_qv/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1505:4 ($.definitions.DscNodeConfigurationCreateOrUpdateParameters)
Process() cancelled due to exception : Cancellation requested.
Cancellation requested. |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmp6ua4ww47/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.100', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.104)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2015-10"} .
Processing batch task - {"tag":"package-2017-05-preview"} .
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:243:4 ($.definitions.JobStreamProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2180:4 ($.definitions.JobStreamProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:114:4 ($.definitions.JobProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:2085:4 ($.definitions.JobProperties)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:95:4 ($.definitions.Job)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1879:4 ($.definitions.Job)
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/preview/2017-05-15-preview/definitions.json:1584:4 ($.definitions.JobCreateProperties)
- file:///tmp/tmp6ua4ww47/rest/specification/automation/resource-manager/Microsoft.Automation/stable/2015-10-31/definitions.json:1893:4 ($.definitions.JobCreateProperties)
Process() cancelled due to exception : Cancellation requested.
Failure during batch task - {"tag":"package-2017-05-preview"} -- Cancellation requested..
Cancellation requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we get too far, could you address the breaking changes?
@@ -60,7 +60,7 @@ | |||
"description": "Gets or sets a Boolean value that indicates true if the parameter is dynamic." | |||
}, | |||
"position": { | |||
"type": "boolean", | |||
"type": "integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change for code gen in most or all languages, and this swagger is in the stable
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our SDK is still in preview mode and open for breaking changes (https://www.nuget.org/packages/Microsoft.Azure.Management.Automation/3.0.1-preview). Also, from what I understood, the service returns integer and not boolean, which is why we corrected this and changed to integer type from boolean.
@avkaur Could you please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that's right.
Are these changes deployed to the server and ready for me to merge the swagger? |
gentle ping, @avkaur |
I'm going to close this PR as stale. Feel free to comment on this thread again and I'll open it right up, or open a new PR. |
It looks like there are some conflicts. Please fix them before I merge. |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Hi @avkaur - After the refactoring of the specs, the definition files have been removed. You'll need to close this issue and redo the changes. |
Closing as per @vrdmr's recommendation above. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger