Creating separate csharp readme for multiApi support #2954
Conversation
shahabhijeet
requested review from
DeepakRajendranMsft,
MikhailTryakhov and
schaabs
as code owners
Automation for azure-libraries-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
|
@lmazuel I had an offline discussion with @shahabhijeet . It seems he has specific requirements on creating the tags and seperate readme files for C#. I am not sure how your tool will be able to handle the requirements. So, I am sending this PR to you to take a look |
|
|
||
| ## Common C# Settings | ||
|
|
||
| ``` yaml !$(MultiApi) |
There was a problem hiding this comment.
@fearthecowboy Just to confirm, MultiApi and multiapi are the same for Autorest bootstrap? IOW, If I call autorest --multiapi does it trigger correctly MultiApi here?
There was a problem hiding this comment.
LGTM, just want @fearthecowboy to confirm explicit that MultiApi and multiapi are always interpreted the same by Autorest, since Go and Python uses --multiapi and this C# PR is using --MultiApi.
If they are not interpreted the same, I would suggest to rename all the MultiApi here to multiapi for consistency with the already existing configuration.
|
Oh, my bad -- yeah they should be the same. |
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
1 similar comment
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
| ApiVersionName: Api2017_10_01 | ||
| ``` | ||
|
|
||
| ## Tag: Packages for Azure Stack |
There was a problem hiding this comment.
@shahabhijeet why is that? All tags should be in the main Readme, this file is not for tag definition but for C# specifics definition
There was a problem hiding this comment.
@lmazuel this is the first time we are trying to do something for AzureStack, and we ourselves do not know if this is the right thing to do, as we need feedback from AzureStack team.
So once we have an agreement and things are set in place, these tags will be moved to main readme.md, hence right now they are only C# AzureStack specific and are not ready to be consumed by anyone else outside C# SDK
There was a problem hiding this comment.
As long as you tell me that it's temporary and experimental, and will not spread across all the Readme, I'm fine :)
…or CSharp generation. Adding tags for Resoruce Manager azure stack multiapi generation.
shahabhijeet
added
the
DoNotMerge
|
@lmazuel @sarangan12 requirements from azure stack is still changing. |
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/authorization/resource-manager/readme.md
|
shahabhijeet
removed
the
DoNotMerge
|
@sarangan12 @lmazuel this PR is finalize and is ready to be merged. |
Automation for azure-sdk-for-rubyThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Creating separate csharp readme
Adding multi api sections in the csharp configs