Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added autoOSUpgradePolicy to UpgradePolicy #2990

Merged
merged 2 commits into from
May 8, 2018
Merged

added autoOSUpgradePolicy to UpgradePolicy #2990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e4037
added autoOSUpgradePolicy
May 1, 2018
27752fd
added deafult value as false
May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5952,6 +5952,15 @@
},
"description": "Describes a virtual machine scale set sku."
},
"AutoOSUpgradePolicy": {
"properties": {
"disableAutoRollback": {
"type": "boolean",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the ARM team discourages the use of booleans. Is this API already deployed/finished?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marstr service side code changes are done. Not sure if that is what you asked. There isn't anything pending from our side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this already executing on the server, and that it would be a breaking change to fix now:

Given that this is a new linter error, we're going to also need to add a suppression. Before that happens, we'll will need to be acknowledged by @ravbhatnagar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar gentle ping :-)

"description": "Whether OS image rollback feature should be disabled. Default value is false."
}
},
"description": "The configuration parameters used for performing automatic OS upgrade."
},
"UpgradePolicy": {
"properties": {
"mode": {
Expand All @@ -5974,6 +5983,10 @@
"automaticOSUpgrade": {
"type": "boolean",
"description": "Whether OS upgrades should automatically be applied to scale set instances in a rolling fashion when a newer version of the image becomes available."
},
"autoOSUpgradePolicy":{
"$ref": "#/definitions/AutoOSUpgradePolicy",
"description": "Configuration parameters used for performing automatic OS Upgrade."
}
},
"description": "Describes an upgrade policy - automatic, manual, or rolling."
Expand Down