Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added autoOSUpgradePolicy to UpgradePolicy #2990

Merged
merged 2 commits into from
May 8, 2018
Merged

added autoOSUpgradePolicy to UpgradePolicy #2990

merged 2 commits into from
May 8, 2018

Conversation

sds6
Copy link
Contributor

@sds6 sds6 commented May 1, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from marstr May 1, 2018 16:03
@AutorestCI AutorestCI mentioned this pull request May 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 1, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2710

@AutorestCI
Copy link

AutorestCI commented May 1, 2018 •
edited
Loading

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#2

@AutorestCI AutorestCI mentioned this pull request May 1, 2018
Open
@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️0 new Warnings.(81 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️1 new Warnings.(57 total)
Code Id Source Message
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableAutoRollback
❌0 new Errors.(11 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI AutorestCI mentioned this pull request May 1, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented May 1, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2487

@AutorestCI AutorestCI mentioned this pull request May 1, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented May 1, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1813

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️0 new Warnings.(81 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/compute/resource-manager/readme.md

⚠️1 new Warnings.(57 total)
Code Id Source Message
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableAutoRollback
❌0 new Errors.(11 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI AutorestCI mentioned this pull request May 2, 2018
Merged
marstr
marstr requested changes May 2, 2018
View reviewed changes
specification/compute/resource-manager/Microsoft.Compute/stable/2017-12-01/compute.json
"AutoOSUpgradePolicy": {
"properties": {
"disableAutoRollback": {
"type": "boolean",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the ARM team discourages the use of booleans. Is this API already deployed/finished?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marstr service side code changes are done. Not sure if that is what you asked. There isn't anything pending from our side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that this already executing on the server, and that it would be a breaking change to fix now:

Given that this is a new linter error, we're going to also need to add a suppression. Before that happens, we'll will need to be acknowledged by @ravbhatnagar.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravbhatnagar gentle ping :-)

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 2, 2018
@marstr marstr requested a review from ravbhatnagar May 2, 2018 23:14
@ravbhatnagar
Copy link
Contributor

Signing off from ARM. @sds6 - Please evangelize in your team that API changes need to be reviewed before the service changes hit prod. Going forward, ARM will not be signing off on API changes and will require you to address issues before approving.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 8, 2018
@sds6
Copy link
Contributor Author

sds6 commented May 8, 2018

@ravbhatnagar thank you. Will keep that in mind

@marstr
Copy link
Member

marstr commented May 8, 2018

Let me know when you're ready to merge, @sds6.

@marstr
Copy link
Member

marstr commented May 8, 2018

I got word offline that the RP is ready to merge.

@marstr marstr merged commit f3c8724 into Azure:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstr marstr marstr approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@marstr marstr

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sds6 @AutorestCI @azuresdkciprbot @ravbhatnagar @marstr