-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAI] v2024_07_01_preview
service release remaining points
#29967
Merged
trrwilson
merged 3 commits into
feature/aoai-2024-07-01-preview-tsp
from
jpalvarezl/2024_07_01p_gaps
Jul 29, 2024
Merged
[OpenAI] v2024_07_01_preview
service release remaining points
#29967
trrwilson
merged 3 commits into
feature/aoai-2024-07-01-preview-tsp
from
jpalvarezl/2024_07_01p_gaps
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalvarezl
requested review from
vicancy and
MushMal
and removed request for
a team
July 25, 2024 13:55
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
This was referenced Jul 25, 2024
trrwilson
approved these changes
Jul 29, 2024
trrwilson
merged commit Jul 29, 2024
b9872e1
into
feature/aoai-2024-07-01-preview-tsp
18 of 27 checks passed
lmazuel
pushed a commit
that referenced
this pull request
Aug 20, 2024
* (incomplete) some initial definitions * chunking strategy + examples * examples * readme+fixing examples * file examples for inference * different model for request/response * Fixing inference readme + bing search tool * format * updated the batches routes * no warnings for batches! * added batch examples * [OpenAI] `v2024_07_01_preview` service release remaining points (#29967) * TSP changes * Compilation related swagger gen * Removed unused comment section * post-merge: format/compile and address example JSON warnings * prettier, spellcheck, example fixes * npx tsp format **/*tsp * more example and validation fixes * one more fix * Added mismatched code block marker * Commented out service team entry in the readme * remove deferred parallel_tool_calls * defer 'browser' tool to future version (removing it) * Uncommented entry for service release * Recompiled project * Adding the only method that works * Adding model to be emitted in the custom model subpackage * Updated useDependency version for client and removed nullability from constant * Added compiler warning supressions * format fixes for assistants * Using OpenAIPageableListOf type as in assistants * remove stream_options * TSP validtion check * Update specification/cognitiveservices/OpenAI.Inference/routes/batches.tsp Verified against service spec and OpenAI spec Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> * make license optional * Adding missing documentation to query params in get batches list * Made page of data fields optional * Project compile * Added request object for batches as full model instead of spreading it * Reverted statusCode 201 change for batches create op * Example fix and statusCode correct swagger gen * Reformat * reformat --------- Co-authored-by: Gerardo Lecaros <10088504+glecaros@users.noreply.github.com> Co-authored-by: Chris Schraer <chris_schraer@users.noreply.github.com> Co-authored-by: Jose Alvarez <jpalvarezl@users.noreply.github.com> Co-authored-by: Jose Alvarez <jp.alvarezl@gmail.com> Co-authored-by: Jose Alvarez <josealvar@microsoft.com> Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features missing in base branch added in this PR
MessageTextUrlCitationAnnotation
and streaming counterpartBingSearch
tool forrun_step
endpoints and streaming counterpartparallel_tool_call
flag forrun
request objectschunkingStratetegy
for ad-hoc model fortool_resource
creation