Added missing APIs to complete RP-ARM SLA #3031

akumardu · 2018-05-07T21:14:29Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-05-07T21:17:00Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2540

AutorestCI · 2018-05-07T21:17:49Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2625

AutorestCI · 2018-05-07T21:17:57Z

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#43

azuresdkciprbot · 2018-05-07T21:19:04Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(28 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-07T21:19:04Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2018-05-07T21:20:56Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1805

jianghaolu · 2018-05-07T21:58:42Z

...thub/resource-manager/Microsoft.Devices/stable/2018-04-01/examples/iothub_testallroutes.json

+                "name": "Route id",
+                "source": "DeviceMessages",
+                "endpointNames": ["id1", "id2"],
+                "isEnabled": "true"


This should be a boolean.

jianghaolu · 2018-05-07T21:59:25Z

specification/iothub/resource-manager/Microsoft.Devices/stable/2018-04-01/iothub.json

+          {
+            "name": "resourceName",
+            "in": "path",
+


Remove empty lines.

jianghaolu

Couple minor issues - please take a look.

azuresdkciprbot · 2018-05-08T23:12:13Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(28 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-08T23:12:13Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-05-09T18:46:58Z

...thub/resource-manager/Microsoft.Devices/stable/2018-04-01/examples/iothub_testallroutes.json

+            "properties": {
+                "name": "Route id",
+                "source": "DeviceMessages",
+                "endpointNames": ["id1", "id2"],


Sorry for the late response. Here is another issue I found - this array is defined to have max length of 1: https://github.com/Azure/azure-rest-api-specs/pull/3031/files#diff-54dafbe4198f749bac837b913372bcddR2417

Good catch !

azuresdkciprbot · 2018-05-09T21:43:09Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-09T21:43:09Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(28 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-05-09T22:15:56Z

...othub/resource-manager/Microsoft.Devices/stable/2018-04-01/examples/iothub_testnewroute.json

+        "source": "DeviceMessages",
+        "endpointNames": [
+          "id1",
+          "id2"


Thanks for addressing my comment - please also fix it here.

azuresdkciprbot · 2018-05-09T23:34:58Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(28 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-09T23:34:58Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jianghaolu · 2018-05-09T23:35:13Z

...thub/resource-manager/Microsoft.Devices/stable/2018-04-01/examples/iothub_testallroutes.json

+        "routes": [
+          {
+            "properties": {
+                "name": "Route id",


Name doesn't match requirement ^[A-Za-z0-9-._]{1,64}$: https://github.com/Azure/azure-rest-api-specs/pull/3031/files#diff-54dafbe4198f749bac837b913372bcddR2393

jianghaolu · 2018-05-09T23:35:24Z

...othub/resource-manager/Microsoft.Devices/stable/2018-04-01/examples/iothub_testnewroute.json

+        "systemProperties": "System Properties"
+      },
+      "route": {
+        "name": "Route id",


azuresdkciprbot · 2018-05-09T23:53:49Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(9 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-09T23:53:49Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/iothub/resource-manager/readme.md

⚠️

0 new Warnings.(28 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Async PATCH must include 201 response. Fixing DeviceUpdate, SCVMM and VMWare RPs to ensure the upcoming code in RPaaS doesn't break virtualMachines resource type

Amar Kumar Dubedy added 2 commits April 19, 2018 15:24

Added missing APIs

9a9a2c0

Updated as per latest commits

2a52cc2

azuresdkci assigned jianghaolu May 7, 2018

azuresdkci requested a review from jianghaolu May 7, 2018 21:16

AutorestCI mentioned this pull request May 7, 2018

[AutoPR iothub/resource-manager] Added missing APIs to complete RP-ARM SLA Azure/azure-sdk-for-python#2540

Closed

AutorestCI mentioned this pull request May 7, 2018

[AutoPR iothub/resource-manager] Added missing APIs to complete RP-ARM SLA Azure/azure-sdk-for-node#2845

Closed

AutorestCI mentioned this pull request May 7, 2018

[AutoPR iothub/resource-manager] Added missing APIs to complete RP-ARM SLA AutorestCI/azure-libraries-for-java#146

Open

AutorestCI mentioned this pull request May 7, 2018

[AutoPR iothub/resource-manager] Added missing APIs to complete RP-ARM SLA Azure/azure-sdk-for-go#1805

Merged

jianghaolu reviewed May 7, 2018

View reviewed changes

jianghaolu suggested changes May 7, 2018

View reviewed changes

Resolved PR comments

17c0111

jianghaolu suggested changes May 9, 2018

View reviewed changes

Resolved CR comment

8187089

jianghaolu reviewed May 9, 2018

View reviewed changes

Updating example to show endpoints are limited to one entry only

c894251

jianghaolu reviewed May 9, 2018

View reviewed changes

More fixes corresponding to swagger

e4ff6dc

jianghaolu approved these changes May 10, 2018

View reviewed changes

jianghaolu merged commit a73217d into Azure:master May 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added missing APIs to complete RP-ARM SLA #3031

Added missing APIs to complete RP-ARM SLA #3031

akumardu commented May 7, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

azuresdkciprbot commented May 7, 2018

azuresdkciprbot commented May 7, 2018

AutorestCI commented May 7, 2018 •

edited

Loading

jianghaolu May 7, 2018

akumardu May 8, 2018

jianghaolu May 7, 2018

jianghaolu left a comment

azuresdkciprbot commented May 8, 2018

azuresdkciprbot commented May 8, 2018

jianghaolu May 9, 2018

akumardu May 9, 2018

azuresdkciprbot commented May 9, 2018

azuresdkciprbot commented May 9, 2018

jianghaolu May 9, 2018

azuresdkciprbot commented May 9, 2018

azuresdkciprbot commented May 9, 2018

jianghaolu May 9, 2018

jianghaolu May 9, 2018

azuresdkciprbot commented May 9, 2018

azuresdkciprbot commented May 9, 2018

Added missing APIs to complete RP-ARM SLA #3031

Added missing APIs to complete RP-ARM SLA #3031

Conversation

akumardu commented May 7, 2018 • edited by azuresdkci Loading

PR information

Quality of Swagger

AutorestCI commented May 7, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented May 7, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented May 7, 2018 • edited Loading

Automation for azure-libraries-for-java

azuresdkciprbot commented May 7, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 7, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

AutorestCI commented May 7, 2018 • edited Loading

Automation for azure-sdk-for-go

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jianghaolu left a comment

Choose a reason for hiding this comment

azuresdkciprbot commented May 8, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 8, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azuresdkciprbot commented May 9, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 9, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Choose a reason for hiding this comment

azuresdkciprbot commented May 9, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

azuresdkciprbot commented May 9, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azuresdkciprbot commented May 9, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

azuresdkciprbot commented May 9, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

akumardu commented May 7, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

AutorestCI commented May 7, 2018 •

edited

Loading

AutorestCI commented May 7, 2018 •

edited

Loading