Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up Actions issues #31252

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Fix up Actions issues #31252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7dc4b86
fail-fast: false
danieljurek Oct 26, 2024
1243a12
Write-Host instead of Write-Error, judge failure from exit code
danieljurek Oct 26, 2024
c300185
Option 1: Continue processing when an error is written out. Nonzero e…
danieljurek Oct 26, 2024
454bd70
Undo eng/scripts/Logging-Functions.ps1
danieljurek Oct 26, 2024
39bf0e6
Revert typespec-requirement.yaml
danieljurek Oct 26, 2024
704a697
Put ErrorActionPreference in the right place
danieljurek Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/typespec-validation-all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
typespec-validation-all:
name: TypeSpec Validation All
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
# shards must start at 0 and increment by 1
Expand All @@ -57,13 +58,14 @@ jobs:

- name: Validate All Specs
run: |
# Keep processing when errors are written. Nonzero exit will mark the
# step as failed.
$ErrorActionPreference = 'Continue'

./eng/scripts/TypeSpec-Validation.ps1 `
-Shard ${{ matrix.shard }} `
-TotalShards ${{ matrix.total-shards }} `
-CheckAll `
-GitClean `
-Verbose

# Effectively the same as ignoreLASTEXITCODE: true in Azure DevOps
exit 0
shell: pwsh
11 changes: 8 additions & 3 deletions .github/workflows/typespec-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,13 @@ jobs:

- name: Validate Impacted Specs
run: |
# Keep processing when errors are written. Nonzero exit will mark the
# step as failed.
$ErrorActionPreference = 'Continue'

eng/scripts/TypeSpec-Requirement.ps1 `
-BaseCommitish HEAD^ `
-TargetCommitish HEAD `
-SpecType ${{ matrix.spec-type }}
./eng/scripts/TypeSpec-Validation.ps1 -GitClean -Verbose

# Effectively the same as ignoreLASTEXITCODE: true in Azure DevOps
exit 0
shell: pwsh