Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uiDefinitionUri property from managed app responses and add new api version #3154

Merged
merged 6 commits into from
Jun 5, 2018

Conversation

olsoro
Copy link
Contributor

@olsoro olsoro commented May 30, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@olsoro
Copy link
Contributor Author

olsoro commented May 30, 2018

@vivsriaus please review

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3nm_u4kt/rest/specification/resources/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp3nm_u4kt/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
[Exception] No input files provided.

Use --help to get help information.

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#154

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2570

@AutorestCI
Copy link

AutorestCI commented May 30, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1970

Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README with this new API version.

@vivsriaus
Copy link
Contributor

LGTM

@olsoro
Copy link
Contributor Author

olsoro commented May 30, 2018

@jhendrixMSFT - Please take a look, I've addressed your comment.

@jhendrixMSFT
Copy link
Member

@olsoro Thanks that part looks good. Can you please take a look at the linter and model validation failures in CI, specifically the ones where PR_ONLY=true.

@olsoro
Copy link
Contributor Author

olsoro commented Jun 1, 2018

@jhendrixMSFT Those failures are not related to my changes, can we ignore them?

@jhendrixMSFT
Copy link
Member

@olsoro We can but please note that the expectation is for new swaggers and/or API versions they should be linter/modeler clean, and these issues will be reported in S360.
At a minimum the semantic validation errors must be fixed. For this issue you want to use the x-ms-paths extension with a dummy query param to distinguish the two cases. It would also be ideal to add a regex that validates the path param ID conforms to the expected pattern but that's not a blocking issue.

@jhendrixMSFT
Copy link
Member

Here's an example using x-ms-paths. Since your query params are dummies to distinguish the cases omit the "op" query param.

@olsoro
Copy link
Contributor Author

olsoro commented Jun 5, 2018

@jhendrixMSFT I've addressed your comment about particular semantic validation failure. Please take a look if this is what was expected.

@jhendrixMSFT jhendrixMSFT merged commit ac44797 into Azure:master Jun 5, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
…gerV6

Add arc related defintions for AzureStackHCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants