-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uiDefinitionUri property from managed app responses and add new api version #3154
Conversation
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
@vivsriaus please review |
Automation for azure-sdk-for-nodeEncountered a Subprocess error: (azure-sdk-for-node)
Command: ['/usr/local/bin/autorest', '/tmp/tmp3nm_u4kt/rest/specification/resources/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp3nm_u4kt/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43'] AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
[Exception] No input files provided.
Use --help to get help information. |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README with this new API version.
LGTM |
@jhendrixMSFT - Please take a look, I've addressed your comment. |
@jhendrixMSFT Those failures are not related to my changes, can we ignore them? |
@olsoro We can but please note that the expectation is for new swaggers and/or API versions they should be linter/modeler clean, and these issues will be reported in S360. |
Here's an example using x-ms-paths. Since your query params are dummies to distinguish the cases omit the "op" query param. |
…into removeuidefinitionuri
bf238df
to
79e260d
Compare
@jhendrixMSFT I've addressed your comment about particular semantic validation failure. Please take a look if this is what was expected. |
…gerV6 Add arc related defintions for AzureStackHCI
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger