-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] remove maxPods default #3178
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: ['/usr/local/bin/autorest', '/tmp/tmpm7qwp5m6/rest/specification/containerservices/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpm7qwp5m6/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--use=@microsoft.azure/autorest.go@~2.1.100', '--use-onever', '--verbose'] AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Loading AutoRest core '/root/.autorest/@microsoft.azure_autorest-core@2.0.4278/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4278)
Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.100->2.1.100)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2017-09"} .
FATAL: swagger-document/compose - FAILED
FATAL: Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
-
VNet SubnetID specifies the vnet's subnet identifier. If you specify either
master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
have to be in the same VNet.
).
Process() cancelled due to exception : '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
-
VNet SubnetID specifies the vnet's subnet identifier. If you specify either
master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
have to be in the same VNet.
).
Failure during batch task - {"tag":"package-2017-09"} -- Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
-
VNet SubnetID specifies the vnet's subnet identifier. If you specify either
master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
have to be in the same VNet.
)..
Error: '$.definitions.ContainerServiceVnetSubnetID.description' has incompatible values (---
VNet SubnetID specifies the vnet's subnet identifier.
, ---
-
VNet SubnetID specifies the vnet's subnet identifier. If you specify either
master VNet Subnet, or agent VNet Subnet, you need to specify both. And they
have to be in the same VNet.
). |
Automation for azure-libraries-for-javaA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for fixing this!
@lmazuel could we make this change before the Python SDK gets published from Azure/azure-sdk-for-python#2186? |
@mboersma Definitely. |
The default of 30 here was a mistake. The common case will be to
null
this field out and let AKS + Kubernetes determine the default (currently 110).We discovered this issue during "bug bash" testing today. I will work around it in the
az
CLI but SDKs and docs shouldn't have this as default.cc: @JunSun17 @weinong
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger