Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User identities in a new dictionary property #3183

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

nkuchta
Copy link
Contributor

@nkuchta nkuchta commented Jun 5, 2018

Moving user identities API surface from the list property "identityId" to a new dictionary property named "userAssignedIdentities".

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Moving user identities support from the property "identityId" list to a new dictionary property named "userAssignedIdentities".
@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2710

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#2

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2487

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1422

@AutorestCI
Copy link

AutorestCI commented Jun 5, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

The following issues were found in Gopkg.toml:

  ✗ unable to deduce repository and source type for "golang.org/x/tools": unable to read metadata: go-import metadata not found

ProjectRoot name validation failed

@anuchandy
Copy link
Member

@ravbhatnagar, this is to support merge-patch for user assigned identities.

//cc @johanste

@anuchandy anuchandy requested a review from ravbhatnagar June 12, 2018 06:33
@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 12, 2018
@ravbhatnagar
Copy link
Contributor

Looks good

@anuchandy
Copy link
Member

status [as of June/13]: this api version is not yet deployed to production.

@nkuchta
Copy link
Contributor Author

nkuchta commented Jun 29, 2018

@anuchandy This API version has now been deployed.

@anuchandy
Copy link
Member

@nkuchta can you please sync with @dochung4 [Dongwook Chung] on this comment #3302 (comment)? I assume those changes has to be made to 2018-06-01 as well.

// cc @lmazuel

@nkuchta
Copy link
Contributor Author

nkuchta commented Jul 2, 2018

@anuchandy, this change should be independent of that effort. I've asked @dochung4 to follow up with his team to get his changes reconciled into this API version.

@anuchandy
Copy link
Member

@nkuchta thank you!, merging this PR.

@anuchandy anuchandy merged commit e450041 into Azure:master Jul 2, 2018
@AutorestCI
Copy link

AutorestCI commented Jul 2, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants