Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new property isBootstrapCertificate to CSES #31851

Conversation

avilgoelms
Copy link
Contributor

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Dec 12, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Dec 12, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute There is no API change compared with the previous version
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=d84f641959c74d12b035475875abc6f5
JavaScript @azure/arm-compute https://apiview.dev/Assemblies/Review/a802869b6345406cbb6d1e487132d7dd?revisionId=e30484087a3f4e9198b3476b081c6dfa
.Net Azure.ResourceManager.Compute https://apiview.dev/Assemblies/Review/7fec998c6beb4201bb99c335d06c70fa?revisionId=dfed435bcc7e428aabd6a75c5e5e22b5

Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the prettier check and target this to main branch.

Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change bool to boolean, also please run the prettier check on example file and target this to main branch.

@grizzlytheodore
Copy link
Member

Please address haider comment. That should resolve most of the failing CI failures.
But we want to have lintdiff, modelvalidation, prettiercheck, and semanticvalidation all passing

@grizzlytheodore grizzlytheodore merged commit c52030c into Azure:feature/cplat-2024-11-04 Dec 17, 2024
24 of 25 checks passed
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Dec 17, 2024
grizzlytheodore added a commit that referenced this pull request Dec 20, 2024
* create new version folder

* update version references

* update readme

* Adding new property isBootstrapCertificate to CSES (#31851)

* adding isBootstrapCertificate property

* addressing PR comments

* running prettier

---------

Co-authored-by: avilgoelms <163285360+avilgoelms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants