-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new api versions for PriceSheet and UsageDetail #3187
Conversation
Automation for azure-sdk-for-pythonEncountered an unknown error: (azure-sdk-for-python)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
sdk_tag=sdk_tag
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 297, in generate_sdk_from_git_object
commit_sha = do_commit(sdk_repo, message, branch_name, commit_for_sha.sha)
File "/usr/local/lib/python3.6/dist-packages/github/GitCommit.py", line 92, in sha
self._completeIfNotSet(self._sha)
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 259, in _completeIfNotSet
self._completeIfNeeded()
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 263, in _completeIfNeeded
self.__complete()
File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 268, in __complete
self._url.value
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 185, in requestJsonAndCheck
return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 198, in __check
raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 502 {'message': 'Server Error'} |
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
"tags": [ | ||
"UsageDetails" | ||
], | ||
"operationId": "UsageDetailsByBillingAccount_List", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] I'd reduce the number of times folks have to instantiate new clients/authenticate them by consolidating the operation groups here. For example:
UsageDetailsByBillingAccount_List
->UsageDetails_ListByBillingAccount
UsageDetailsByDepartment_List
->UsageDetails_ListByDepartment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Just waiting for @ravbhatnagar now. |
After chatting with Khalid, it looks like one new read only property (offerId) got added to the response of pricesheets . And similarly, 4 new readonly properties got added to the response of usageDetails. |
@ms-premp fyi. |
Hi @marstr ... ARM signoff is complete. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger