Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new api versions for PriceSheet and UsageDetail #3187

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

kc786
Copy link
Contributor

@kc786 kc786 commented Jun 6, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 297, in generate_sdk_from_git_object
    commit_sha = do_commit(sdk_repo, message, branch_name, commit_for_sha.sha)
  File "/usr/local/lib/python3.6/dist-packages/github/GitCommit.py", line 92, in sha
    self._completeIfNotSet(self._sha)
  File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 259, in _completeIfNotSet
    self._completeIfNeeded()
  File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 263, in _completeIfNeeded
    self.__complete()
  File "/usr/local/lib/python3.6/dist-packages/github/GithubObject.py", line 268, in __complete
    self._url.value
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 185, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
  File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 198, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 502 {'message': 'Server Error'}

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2700

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2011

"tags": [
"UsageDetails"
],
"operationId": "UsageDetailsByBillingAccount_List",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] I'd reduce the number of times folks have to instantiate new clients/authenticate them by consolidating the operation groups here. For example:

  • UsageDetailsByBillingAccount_List -> UsageDetails_ListByBillingAccount
  • UsageDetailsByDepartment_List -> UsageDetails_ListByDepartment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2018
@marstr marstr requested a review from ravbhatnagar June 6, 2018 17:12
@marstr
Copy link
Member

marstr commented Jun 7, 2018

Just waiting for @ravbhatnagar now.

@ravbhatnagar
Copy link
Contributor

After chatting with Khalid, it looks like one new read only property (offerId) got added to the response of pricesheets . And similarly, 4 new readonly properties got added to the response of usageDetails.
Looks good. Signing off from ARM.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 8, 2018
@ms-premp
Copy link
Contributor

ms-premp commented Jun 8, 2018

@ms-premp fyi.

@ms-premp
Copy link
Contributor

ms-premp commented Jun 8, 2018

Hi @marstr ... ARM signoff is complete.
As mentioned .. we are adding a few new fields in existing API, under a new version.
Please review and merge.

@marstr marstr merged commit c2f3210 into Azure:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants