Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primary flag to 2015-06-15 NetworkInterfaceIPConfiguration #3200

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Add primary flag to 2015-06-15 NetworkInterfaceIPConfiguration #3200

merged 1 commit into from
Jun 8, 2018

Conversation

seyadava
Copy link
Contributor

@seyadava seyadava commented Jun 8, 2018

Added primary flag to 2015-06-15 NetworkInterfaceIPConfiguration object on NetworkInterface.json spec.
This flags gets populated by api-version 2015-06-15 on Azure and AzureStack. So it is a bug that spec does not hydrate that flag.
Related issues:
Azure/azure-sdk-for-go#1997
#2578

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…rmat object of networkInterface.json definition of Network 2015-06-15 spec
@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2376

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1327

@AutorestCI
Copy link

AutorestCI commented Jun 8, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2001

@jianghaolu jianghaolu merged commit 51f2fe7 into Azure:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants