Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# SDK generation settings for Advisor #3213

Merged
merged 6 commits into from
Jun 28, 2018

Conversation

Prasanna-Padmanabhan
Copy link
Contributor

@Prasanna-Padmanabhan Prasanna-Padmanabhan commented Jun 11, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@Prasanna-Padmanabhan Prasanna-Padmanabhan changed the title Swaggerfix Add C# SDK generation settings for Advisor Jun 11, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 11, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2843

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2018

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmpgjgidths/rest/specification/advisor/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmpgjgidths/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@^2.1.43']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4280; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (^2.1.43->2.1.59)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: System.Exception: Duplicate File Generation: lib/models/configurationListResult.js
   at AutoRest.Core.CodeGenerator.<Write>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Core.CodeGenerator.<Write>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.NodeJS.Azure.CodeGeneratorJsa.<Generate>d__5.MoveNext() in /opt/vsts/work/1/s/src/azure/CodeGeneratorJsa.cs:line 56
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.NodeJS.Program.<ProcessInternal>d__3.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 132
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: nodejs/generate - FAILED
FATAL: Error: Plugin nodejs reported failure.
Process() cancelled due to exception : Plugin nodejs reported failure.
  Error: Plugin nodejs reported failure.

@AutorestCI
Copy link

AutorestCI commented Jun 11, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2156

@lmazuel lmazuel requested review from shahabhijeet and removed request for lmazuel June 12, 2018 21:55
@lmazuel lmazuel assigned shahabhijeet and unassigned lmazuel Jun 12, 2018
@lmazuel
Copy link
Member

lmazuel commented Jun 12, 2018

Give to @shahabhijeet , since pure C# question

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine, but the generated code will not build.
You are modelling your Get operation as long running operation.
Delete the following line
https://github.com/Prasanna-Padmanabhan/azure-rest-api-specs/blob/8f325f540f597ae184379bed0676e8cdfd42039f/specification/advisor/resource-manager/Microsoft.Advisor/stable/2017-04-19/advisor.json#L260

@dsgouda
Copy link
Contributor

dsgouda commented Jun 28, 2018

LGTM @shahabhijeet Please approve so we can merge

@dsgouda dsgouda merged commit 279d7a9 into Azure:master Jun 28, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 29, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants