Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComputerVision add tag.hint, make scalars non-nullable #3259

Merged
merged 2 commits into from
Jun 20, 2018
Merged

ComputerVision add tag.hint, make scalars non-nullable #3259

merged 2 commits into from
Jun 20, 2018

Conversation

cthrash
Copy link
Contributor

@cthrash cthrash commented Jun 18, 2018 •
edited by azuresdkci
Loading

Hints provided additional info for whole-image analysis tags.
This PR is to make the Swagger match the service behavior.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@cthrash
ComputerVision add tag.hint
6492fb4 
Hints provided additional info for whole-image analysis tags.
This PR is to make the Swagger match the service behavior.
@azuresdkci azuresdkci requested a review from anuchandy June 18, 2018 20:45
@AutorestCI AutorestCI mentioned this pull request Jun 18, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2614

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 18, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2901

This was referenced Jun 18, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1403

@AutorestCI AutorestCI mentioned this pull request Jun 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2033

@cthrash
ComputerVision remove non-nullable scalars (#2)
07a72ba 
Generally the objects may be unspecified, but when specified, the scalars
contained within them, such as confidence scores, are present.

While this is a breaking change w/r/t to v1.0 of the Azure-named SDK, it is
actually an un-breaking change for our customers who have been using the
hand-crafted [SDK](https://github.com/microsoft/cognitive-vision-windows), which
has been the official SDK up to now.
@cthrash cthrash changed the title ComputerVision add tag.hint ComputerVision add tag.hint, make scalars non-nullable Jun 19, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-java#2120

@cthrash
Copy link
Contributor Author

cthrash commented Jun 19, 2018

Is the azure-sdk-for-java issue related to a change I made?

@anuchandy
Copy link
Member

@cthrash looking into the java crash.

@anuchandy
Copy link
Member

@cthrash discussed with dev owning swagger to SDK automation, please ignore this error now. We will take care of it eventually.

@anuchandy anuchandy merged commit 0c74aa6 into Azure:master Jun 20, 2018
@AutorestCI AutorestCI mentioned this pull request Jun 20, 2018
Merged
@cthrash cthrash deleted the cthrash/computervision-tag-hint branch June 20, 2018 18:11
@cthrash cthrash mentioned this pull request Jun 20, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthrash @AutorestCI @anuchandy