Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationInsights: Uses plural for operation group name #3324

Merged
merged 2 commits into from
Jul 2, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,7 @@
"200": {
"description": "successful operation",
"schema": {
"type": "array",
"items": {
"$ref": "#/definitions/Annotation"
}
"$ref": "#/definitions/AnnotationsListResult"
}
},
"default": {
Expand Down Expand Up @@ -246,6 +243,19 @@
}
}
},
"AnnotationsListResult": {
"properties": {
"value": {
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/Annotation"
},
"description": "An array of annotations."
}
},
"description": "Annotations list result."
},
"InnerError": {
"type": "object",
"description": "Inner error",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,7 @@
"200": {
"description": "successful operation",
"schema": {
"type": "array",
"items": {
"$ref": "#/definitions/WorkItemConfiguration"
}
"$ref": "#/definitions/WorkItemConfigurationsListResult"
}
},
"default": {
Expand Down Expand Up @@ -218,6 +215,19 @@
}
}
},
"WorkItemConfigurationsListResult": {
"properties": {
"value": {
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/WorkItemConfiguration"
},
"description": "An array of work item configurations."
}
},
"description": "Work item configuration list result."
},
"WorkItemCreateConfiguration": {
"type": "object",
"description": "Work item configuration creation payload",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/components/{resourceName}/favorites/{favoriteId}": {
"get": {
"description": "Get a single favorite by its FavoriteId, defined within an Application Insights component.",
"operationId": "Favorite_Get",
"operationId": "Favorites_Get",
"parameters": [
{
"$ref": "#/parameters/ResourceGroupNameParameter"
Expand Down Expand Up @@ -119,7 +119,7 @@
},
"put": {
"description": "Adds a new favorites to an Application Insights component.",
"operationId": "Favorite_Add",
"operationId": "Favorites_Add",
"parameters": [
{
"$ref": "#/parameters/ResourceGroupNameParameter"
Expand Down Expand Up @@ -162,7 +162,7 @@
},
"patch": {
"description": "Updates a favorite that has already been added to an Application Insights component.",
"operationId": "Favorite_Update",
"operationId": "Favorites_Update",
"parameters": [
{
"$ref": "#/parameters/ResourceGroupNameParameter"
Expand Down Expand Up @@ -205,7 +205,7 @@
},
"delete": {
"description": "Remove a favorite that is associated to an Application Insights component.",
"operationId": "Favorite_Delete",
"operationId": "Favorites_Delete",
"parameters": [
{
"$ref": "#/parameters/ResourceGroupNameParameter"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"200": {
"description": "A list containing 0 or more workbook definitions.",
"schema": {
"$ref": "#/definitions/Workbooks"
"$ref": "#/definitions/WorkbooksListResult"
}
},
"default": {
Expand All @@ -72,6 +72,9 @@
}
}
},
"x-ms-pageable": {
"nextLinkName": null
},
"x-ms-examples": {
"WorkbooksList": {
"$ref": "./examples/WorkbooksList.json"
Expand All @@ -82,7 +85,7 @@
"/subscriptions/{subscriptionId}/resourceGroup/{resourceGroupName}/providers/microsoft.insights/workbooks/{resourceName}": {
"get": {
"description": "Get a single workbook by its resourceName.",
"operationId": "Workbook_Get",
"operationId": "Workbooks_Get",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -119,7 +122,7 @@
},
"delete": {
"description": "Delete a workbook.",
"operationId": "Workbook_Delete",
"operationId": "Workbooks_Delete",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -156,7 +159,7 @@
},
"put": {
"description": "Create a new workbook.",
"operationId": "Workbook_CreateOrUpdate",
"operationId": "Workbooks_CreateOrUpdate",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -208,7 +211,7 @@
},
"patch": {
"description": "Updates a workbook that has already been added.",
"operationId": "Workbook_Update",
"operationId": "Workbooks_Update",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -290,10 +293,11 @@
"x-ms-azure-resource": true,
"description": "An azure resource object"
},
"Workbooks": {
"WorkbooksListResult": {
"properties": {
"value": {
"type": "array",
"readOnly": true,
"items": {
"$ref": "#/definitions/Workbook"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/{scopePath}": {
"get": {
"description": "Gets a list of Analytics Items defined within an Application Insights component.",
"operationId": "AnalyticsItem_List",
"operationId": "AnalyticsItems_List",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -85,7 +85,7 @@
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/{scopePath}/item": {
"get": {
"description": "Gets a specific Analytics Items defined within an Application Insights component.",
"operationId": "AnalyticsItem_Get",
"operationId": "AnalyticsItems_Get",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -125,7 +125,7 @@
},
"put": {
"description": "Adds or Updates a specific Analytics Item within an Application Insights component.",
"operationId": "AnalyticsItem_Put",
"operationId": "AnalyticsItems_Put",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -171,7 +171,7 @@
},
"delete": {
"description": "Deletes a specific Analytics Items defined within an Application Insights component.",
"operationId": "AnalyticsItem_Delete",
"operationId": "AnalyticsItems_Delete",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down
49 changes: 34 additions & 15 deletions specification/applicationinsights/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -356,21 +356,6 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
output-folder: $(go-sdk-folder)/services/appinsights/mgmt/2015-05-01/insights
```


## Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.

``` yaml $(java)
azure-arm: true
fluent: true
namespace: com.microsoft.azure.management.applicationinsights
license-header: MICROSOFT_MIT_NO_CODEGEN
payload-flattening-threshold: 1
output-folder: $(azure-libraries-for-java-folder)/azure-mgmt-applicationinsights
```

### Tag: schema-2015-05-preview

These settings apply only when `--tag=schema-2015-05-01` is specified on the
Expand All @@ -390,4 +375,38 @@ input-file:

override-info:
title: ApplicationInsightsManagementClient
```

## Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.

``` yaml $(java)
azure-arm: true
fluent: true
namespace: com.microsoft.azure.management.applicationinsights
license-header: MICROSOFT_MIT_NO_CODEGEN
payload-flattening-threshold: 1
output-folder: $(azure-libraries-for-java-folder)/azure-mgmt-applicationinsights
```

### Java multi-api

``` yaml $(java) && $(multiapi)
batch:
- tag: package-2015-05
```

### Tag: package-2015-05 and java

These settings apply only when `--tag=package-2015-05 --java` is specified on the command line.
Please also specify `--azure-libraries-for-java=<path to the root directory of your azure-sdk-for-java clone>`.

``` yaml $(tag) == 'package-2015-05' && $(java) && $(multiapi)
java:
namespace: com.microsoft.azure.management.applicationinsights.v2015_05_01
output-folder: $(azure-libraries-for-java-folder)/applicationinsights/resource-manager/v2015_05_01
regenerate-manager: true
generate-interface: true
```