Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding swagger of sensitivity labels APIs. #3373

Merged
merged 3 commits into from
Jul 18, 2018
Merged

Adding swagger of sensitivity labels APIs. #3373

merged 3 commits into from
Jul 18, 2018

Conversation

bashahee
Copy link
Contributor

@bashahee bashahee commented Jul 9, 2018 •
edited
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

bashahee and others added 2 commits July 8, 2018 17:01
@bashahee
Merge pull request #1 from Azure/master
d466b3b 
Sync
@bashahee
Swagger of sensitivity labels APIs
7ddb78c 
Adding swagger containing APIs of sensitivity labels, as long as usage examples of these APIs.
@bashahee bashahee requested a review from jaredmoo July 9, 2018 11:47
@azuresdkci azuresdkci requested a review from hovsepm July 9, 2018 11:47
@AutorestCI AutorestCI mentioned this pull request Jul 9, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1419

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2102

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2715

@AutorestCI AutorestCI mentioned this pull request Jul 9, 2018
Merged
@hovsepm hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Jul 9, 2018

@ravbhatnagar could you take a look to the new swagger spec?

jaredmoo
jaredmoo reviewed Jul 9, 2018
View reviewed changes
...ication/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/sensitivityLabels.json Outdated
},
"x-ms-azure-resource": true
},
"ProxyResource": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please manually remove these and reference common definitions. See other swagger files for examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

...ication/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/sensitivityLabels.json
"type": "object",
"properties": {
"labelName": {
"description": "The label name.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For labelName and informationType, is it freeform text or is there a list of allowed values? If latter - please add enum info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Former.

@bashahee
Reference common definitions.
b19a094 
Reference common definitions.
@bashahee
Copy link
Contributor Author

@hovsepm Can this PR be merged as it was approved?

@hovsepm
Copy link
Contributor

hovsepm commented Jul 11, 2018

@bashahee I'm waiting on ARM review.

@bashahee
Copy link
Contributor Author

@ravbhatnagar Can you please review?

@bashahee
Copy link
Contributor Author

@hovsepm Can you please merge this PR since you approved it?

@hovsepm hovsepm added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 18, 2018
@hovsepm
Copy link
Contributor

hovsepm commented Jul 18, 2018

per email thread response: "if APIs are already in prod it means ARM team reviewed manifest if needed so I don’t think we should block on ARM team anymore"

@hovsepm hovsepm merged commit 5dd98e6 into Azure:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hovsepm hovsepm hovsepm approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

Assignees

@hovsepm hovsepm

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bashahee @AutorestCI @hovsepm @jaredmoo