Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support Azure Disk Encryption & Accelerated Networking #3596

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

sriramvu
Copy link
Contributor

@sriramvu sriramvu commented Aug 7, 2018

Azure Site Recovery (ASR) service has enhanced Azure to Azure (A2A) provider feature support for VMs with encrypted disks and also with accelerated networking.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1560

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2317

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2441

@AutorestCI
Copy link

AutorestCI commented Aug 7, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3324

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update corresponding examples

@@ -6364,6 +6368,30 @@
"format": "double",
"description": "The data pending at source virtual machine in MB.",
"type": "number"
},
"isDiskEncrypted": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please check if any of these properties are readonly

@sriramvu
Copy link
Contributor Author

sriramvu commented Aug 8, 2018

@dsgouda: Azure Site Recovery (ASR) service supports 10+ providers (almost same set of operations each getting distinguished by instanceType in request & response).

All the existing examples are with only one provider HyperV to Azure (E2A) and the current changes are with Azure to Azure (A2A) provider.

Can you please suggest how can we go for updating examples for these specific changes (and in general in future)?

PS: we have AzurePowerShell guiding documentations, sharing one for A2A provider : https://docs.microsoft.com/en-us/azure/site-recovery/azure-to-azure-powershell

@dsgouda
Copy link
Contributor

dsgouda commented Aug 8, 2018

Usually examples are generated from live examples of the REST service traffic. If it is not possible to generate such examples here, that won't be a blocker here

@dsgouda
Copy link
Contributor

dsgouda commented Aug 10, 2018

Talked to @sriramvu since this model is not a part of any PUT/POST request, we can skip marking the properties as readonly for now

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 6eebd7b into Azure:master Aug 10, 2018
@sriramvu sriramvu deleted the master-ADE-AN branch September 17, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants