-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support Azure Disk Encryption & Accelerated Networking #3596
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update corresponding examples
@@ -6364,6 +6368,30 @@ | |||
"format": "double", | |||
"description": "The data pending at source virtual machine in MB.", | |||
"type": "number" | |||
}, | |||
"isDiskEncrypted": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please check if any of these properties are readonly
@dsgouda: Azure Site Recovery (ASR) service supports 10+ providers (almost same set of operations each getting distinguished by instanceType in request & response). All the existing examples are with only one provider HyperV to Azure (E2A) and the current changes are with Azure to Azure (A2A) provider. Can you please suggest how can we go for updating examples for these specific changes (and in general in future)? PS: we have AzurePowerShell guiding documentations, sharing one for A2A provider : https://docs.microsoft.com/en-us/azure/site-recovery/azure-to-azure-powershell |
Usually examples are generated from live examples of the REST service traffic. If it is not possible to generate such examples here, that won't be a blocker here |
Talked to @sriramvu since this model is not a part of any PUT/POST request, we can skip marking the properties as readonly for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Azure Site Recovery (ASR) service has enhanced Azure to Azure (A2A) provider feature support for VMs with encrypted disks and also with accelerated networking.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger