Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extra / on the end of the triggers endpoint #3616

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Aug 9, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2782

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1397

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2434

@hovsepm
Copy link
Contributor

hovsepm commented Aug 9, 2018

@refortie since the PR CI is failing I'll not be able to merge it. The error is following:

AutoRest exited with code 1
{
  "type": "Error",
  "code": "XmsExamplesRequired",
  "message": "Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.",
  "id": "D5001",
  "validationCategory": "Documentation",
  "providerNamespace": null,
  "resourceType": null,
  "sources": [
    "file:///home/travis/build/Azure/azure-rest-api-specs/specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json:36:2 ($.paths)"
  ],
  "jsonref": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json:36:2 ($.paths)",
  "json-path": "file:///home/travis/build/Azure/azure-rest-api-specs/specification/logic/resource-manager/Microsoft.Logic/stable/2016-06-01/logic.json:36:2 ($.paths)"
}

Could you add examples for all the operations?

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2311

@AutorestCI
Copy link

AutorestCI commented Aug 9, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3320

@bsiegel bsiegel force-pushed the fix-workflow-triggers-endpoint branch from 67a2367 to 5a067a6 Compare August 9, 2018 18:34
@hovsepm
Copy link
Contributor

hovsepm commented Aug 9, 2018

Ok. CI is fixed.

@hovsepm hovsepm merged commit e63f725 into Azure:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants