New APIs for sensetivity lables managment in managed instance

[igsiroti]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1562

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2470

[igsiroti]

That PR includes management service APIs for sensitivity labels in managed instance.
Also it adds API to existing version (2017-03-01-preview) for listing recommended labels or current labels (not necessarily both)

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3293

[hovsepm]

@igsiroti please ping me directly when this PR will be ready to review/merge.

[hovsepm]

Please fix Model Validator error:

Validating "examples" and "x-ms-examples" in  specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/sensitivityLabels.json:
Validating "examples" and "x-ms-examples" in  specification/sql/resource-manager/Microsoft.Sql/preview/2018-06-01-preview/sensitivityLabels.json:
 error: 
operationId: SensitivityLabels_ListByDatabase
scenario: >-
  Gets the current and recommended sensitivity labels of a given database in a
  managed instance
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
errorDetails:
  code: REQUIRED_PARAMETER_EXAMPLE_NOT_FOUND
  id: OAV105
  message: >-
    In operation "SensitivityLabels_ListByDatabase", parameter
    sensitivityLabelSource is required in the swagger spec but is not present in
    the provided example parameter values.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''

[hovsepm]

ServerNameParameter [](start = 5, length = 19)

this parameter everywhere was changed to managedInstanceName. There is nor reason to have it here anymore. I'd advice to move ManagedInstanceName definition here and then reference it everywhere in the swagger instead of defining it again and again in each operation parameter list.

[hovsepm]

Please address review comments.

[jaredmoo]

Why was I not included on this review?

Was ManagedDatabaseSensitivityLabels considered for operation name?

[igsiroti]

Hi, sorry my bad. Just saw your OneNote (I'm new to the team)
I followed the way it was done in ManagedInstanceVulnerabilityAssessments - wanted to be consistent. Want me to rename?