Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Cmdlets for Management.Sql to allow customers to add TDE keys and set TDE protector for managed instances #3762

Merged
merged 6 commits into from
Sep 4, 2018
Merged

New Cmdlets for Management.Sql to allow customers to add TDE keys and set TDE protector for managed instances #3762

merged 6 commits into from
Sep 4, 2018

Conversation

nivimsft
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Aug 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2671

@AutorestCI AutorestCI mentioned this pull request Aug 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2138

@nivimsft nivimsft changed the title New Cmdlets for Management.Sql to allow customers to add TDE keys and set TDE protector New Cmdlets for Management.Sql to allow customers to add TDE keys and set TDE protector for managed instances Aug 29, 2018
@AutorestCI AutorestCI mentioned this pull request Aug 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2614

@AutorestCI AutorestCI mentioned this pull request Aug 29, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Aug 29, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3497

@nivimsft
Removing Resource & ProxyResource and adding reference to "../../../c…
4c335c8 
…ommon/v1/types.json#/definitions/ProxyResource"
jaredmoo
jaredmoo reviewed Aug 29, 2018
View reviewed changes
...ce-manager/Microsoft.Sql/preview/2017-10-01-preview/ManagedInstanceEncryptionProtectors.json Outdated
"ManagedInstanceEncryptionProtectors"
],
"description": "Gets a list of managed instance encryption protectors",
"operationId": "ManagedInstanceEncryptionProtectors_ListByServer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ListByInstance

@anuchandy anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2018
anuchandy
anuchandy requested changes Aug 30, 2018
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nivimsft looks good. left some minor comments. please take look.

...ce-manager/Microsoft.Sql/preview/2017-10-01-preview/ManagedInstanceEncryptionProtectors.json Outdated Show resolved Hide resolved
...ce-manager/Microsoft.Sql/preview/2017-10-01-preview/ManagedInstanceEncryptionProtectors.json Show resolved Hide resolved
...ation/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/ManagedInstanceKeys.json Outdated Show resolved Hide resolved
...ation/sql/resource-manager/Microsoft.Sql/preview/2017-10-01-preview/ManagedInstanceKeys.json Show resolved Hide resolved
@nivimsft
Addressed comments By @anuchandy
f5321fc 
- Changed comment to created or updated
- changed operation if to listByInstance
@anuchandy
Copy link
Member

@ravbhatnagar please review, the service is in production and was deployed on 08/26.

@anuchandy anuchandy added ARM-overdue ARM review has not occurred within the expected timeframe and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 4, 2018
@anuchandy anuchandy merged commit 9f1d077 into Azure:master Sep 4, 2018
@nivimsft nivimsft mentioned this pull request Sep 4, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@anuchandy anuchandy

Labels
ARM-overdue ARM review has not occurred within the expected timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nivimsft @azuresdkci @AutorestCI @anuchandy @jaredmoo