Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mariadb swagger spec #3797

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Add mariadb swagger spec #3797

merged 2 commits into from
Sep 12, 2018

Conversation

elemount
Copy link
Contributor

@elemount elemount commented Sep 3, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3332

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2683

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3589

@AutorestCI
Copy link

AutorestCI commented Sep 3, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2387

@dsgouda
Copy link
Contributor

dsgouda commented Sep 4, 2018

@marstr I and @praries880 will be reviewing this together so he gets some experience with this

@dsgouda dsgouda requested review from praries880 and dsgouda and removed request for marstr September 4, 2018 18:22
@dsgouda dsgouda assigned dsgouda and praries880 and unassigned marstr Sep 4, 2018
@dsgouda dsgouda added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Sep 5, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Please refactor your models and apply readonly-ness as pointed out,
Do get a feeling this needs an API review.

@dsgouda
Copy link
Contributor

dsgouda commented Sep 6, 2018

@praries880 do post your comments if you have any

@dsgouda dsgouda removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. Changes Required labels Sep 12, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Sep 12, 2018

API review is complete

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 1cff2ef into Azure:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants