Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventGrid: Updated README.MD configuration to include the new preview API version. #3830

Merged
merged 7 commits into from
Sep 11, 2018

Conversation

kalyanaj
Copy link
Contributor

@kalyanaj kalyanaj commented Sep 7, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…be default-valued. PATCH operation: 'EventSubscriptions_Update' Model Definition: 'EventSubscriptionUpdateParameters' Property: 'eventDeliverySchema'".

2) Updated the default value of EventDeliverySchema to the correct value used by the service.
…1-preview to make it easier to view the diffs).
@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2902

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3574

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1626

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2206

@AutorestCI
Copy link

AutorestCI commented Sep 7, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2663

@kalyanaj
Copy link
Contributor Author

kalyanaj commented Sep 7, 2018

Note: The two ARM linter errors are a tooling issue and is being tracked by: Azure/azure-openapi-arm-validator#10

@sarangan12
Copy link
Member

The changes look good. But the linter issues must be fixed or you should get an exception before merging.

@sarangan12
Copy link
Member

sarangan12 commented Sep 11, 2018

Clarification on the Linter issues provided. This PR Can be merged. Azure/azure-openapi-arm-validator#10

@sarangan12 sarangan12 merged commit 01d6f87 into Azure:master Sep 11, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants