Swagger spec for disk.json + compute.json 2018-06 #3854

carissasun · 2018-09-10T18:54:16Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-10T18:56:48Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-09-10T19:01:46Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2982

azuresdkci · 2018-09-10T19:35:33Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-10T19:36:50Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2685

AutorestCI · 2018-09-10T19:37:53Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-10T19:51:40Z

Automation for azure-sdk-for-node

Encountered a Subprocess error: (azure-sdk-for-node)

Command: ['/usr/local/bin/autorest', '/tmp/tmp7d7bwkcr/rest/specification/compute/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--node-sdks-folder=/tmp/tmp7d7bwkcr/sdk', '--nodejs', '--use=@microsoft.azure/autorest.nodejs@2.1.99']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.11.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4283/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4283)
   Loading AutoRest extension '@microsoft.azure/autorest.nodejs' (2.1.99->2.1.99)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'StorageAccountTypes' and different values: Standard_LRS,Premium_LRS,StandardSSD_LRS,UltraSSD_LRS vs. Standard_LRS,Premium_LRS,StandardSSD_LRS
   at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\ObjectBuilder.cs:line 147
   at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 217
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 48
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SchemaBuilder.cs:line 133
   at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 310
   at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\SwaggerModeler.cs:line 66
   at AutoRest.Modeler.Program.<ProcessInternal>d__2.MoveNext() in C:\Users\ci\AppData\Local\Temp\PUBLISHu1dw1\44_20171214T003644\autorest.modeler\src\Program.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NewPlugin.<Process>d__15.MoveNext()
FATAL: nodejs/imodeler1 - FAILED
FATAL: Error: Plugin imodeler1 reported failure.
Process() cancelled due to exception : Plugin imodeler1 reported failure.
  Error: Plugin imodeler1 reported failure.

lmazuel

Double key in JSON that preventing generation and further testing.

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

yugangw-msft · 2018-09-12T00:19:47Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

+	  "properties": {
+	    "ultraSSDEnabled": {
+	      "type": "boolean",
+          "description": "Enables or disables a capability to have 1 or more managed data disks with UltraSSD_LRS storage account on the VM or VMSS. Managed disks with storage account type UltraSSD_LRS can be added to a virtual machine or virtual machine scale set only if this property is enabled."


can you please fix the indent?

lmazuel · 2018-09-12T21:28:37Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

@@ -5313,6 +5314,15 @@
      },
      "description": "Specifies the storage settings for the virtual machine disks."
    },
+    "AdditionalCapabilities": {
+        "properties": {
+            "ultraSSDEnabled": {


This does not follow ARM guideline naming convention. Even if Gaurav signed-of, I checked with @veronicagg that you should get a suppression rule approved by ARM:
https://github.com/Azure/adx-documentation-pr/wiki/Swagger-Validation-Errors-Suppression

* add "x-ms-secret": true for protectedSettings. * remove protectedSettings from response models.

Carissa Sun added 3 commits May 30, 2018 11:54

removing resourceUpdate, adding contents to disk and snapshot

4abedb1

Merge https://github.com/Azure/azure-rest-api-specs

f0ae2d4

adding swagger spec for disk.json 2018-06-01

e30677b

azuresdkci assigned lmazuel Sep 10, 2018

azuresdkci requested a review from lmazuel September 10, 2018 19:35

AutorestCI mentioned this pull request Sep 10, 2018

[AutoPR compute/resource-manager] Swagger spec for disk.json 2018-06 Azure/azure-sdk-for-go#2651

Closed

AutorestCI mentioned this pull request Sep 10, 2018

[AutoPR compute/resource-manager] Swagger spec for disk.json 2018-06 Azure/azure-sdk-for-node#3557

Closed

lmazuel requested a review from ravbhatnagar September 10, 2018 20:07

lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 10, 2018

lmazuel and others added 4 commits September 10, 2018 13:08

Disks 2018-06-01 for Python

95e04f2

update disk

9f5a173

Merge https://github.com/carissasun/azure-rest-api-specs

3e7cda6

Update readme.md

f128ff0

AutorestCI mentioned this pull request Sep 10, 2018

[AutoPR compute/resource-manager] Swagger spec for disk.json 2018-06 Azure/azure-sdk-for-python#3310

Merged

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 10, 2018

Carissa Sun added 2 commits September 10, 2018 16:41

adding compute.json changes

58a29bf

Merge https://github.com/carissasun/azure-rest-api-specs

f5f7060

lmazuel requested changes Sep 10, 2018

View reviewed changes

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json Outdated Show resolved Hide resolved

lmazuel mentioned this pull request Sep 10, 2018

Swagger changes to compute.json for UltraSSD #3858

Closed

10 tasks

carissasun changed the title ~~Swagger spec for disk.json 2018-06~~ Swagger spec for disk.json + compute.json 2018-06 Sep 11, 2018

deleting duplicates

c5cdad5

yugangw-msft reviewed Sep 12, 2018

View reviewed changes

lmazuel approved these changes Sep 12, 2018

View reviewed changes

Fix indent

9dcfd8c

AutorestCI mentioned this pull request Sep 12, 2018

[AutoPR compute/resource-manager] Swagger spec for disk.json + compute.json 2018-06 Azure/azure-sdk-for-go#2681

Merged

lmazuel reviewed Sep 12, 2018

View reviewed changes

Carissa Sun and others added 3 commits September 12, 2018 15:53

adding suppress

3afcb2d

Merge https://github.com/carissasun/azure-rest-api-specs

12bfdca

Update suppression rules

5b03853

lmazuel approved these changes Sep 12, 2018

View reviewed changes

lmazuel merged commit 5fdf492 into Azure:master Sep 12, 2018

marstr mentioned this pull request Sep 18, 2018

Bringing conformance to the Disk version used in root tags. #3939

Merged

10 tasks

hyonholee mentioned this pull request Sep 27, 2018

[Compute] Update Compute client version to 23.0.0. Azure/azure-sdk-for-net#4809

Merged

9 tasks

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

add "x-ms-secret": true for protectedSettings. (#3854)

02aec3c

* add "x-ms-secret": true for protectedSettings. * remove protectedSettings from response models.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger spec for disk.json + compute.json 2018-06 #3854

Swagger spec for disk.json + compute.json 2018-06 #3854

carissasun commented Sep 10, 2018

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

azuresdkci commented Sep 10, 2018

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

lmazuel left a comment

yugangw-msft Sep 12, 2018

lmazuel Sep 12, 2018 •

edited

Loading

carissasun Sep 12, 2018

Swagger spec for disk.json + compute.json 2018-06 #3854

Swagger spec for disk.json + compute.json 2018-06 #3854

Conversation

carissasun commented Sep 10, 2018

PR information

Quality of Swagger

AutorestCI commented Sep 10, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 10, 2018 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Sep 10, 2018

AutorestCI commented Sep 10, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 10, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Sep 10, 2018 • edited Loading

Automation for azure-sdk-for-node

lmazuel left a comment

Choose a reason for hiding this comment

yugangw-msft Sep 12, 2018

Choose a reason for hiding this comment

lmazuel Sep 12, 2018 • edited Loading

Choose a reason for hiding this comment

carissasun Sep 12, 2018

Choose a reason for hiding this comment

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

AutorestCI commented Sep 10, 2018 •

edited

Loading

lmazuel Sep 12, 2018 •

edited

Loading