Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Added list support to VA policies #3878

Merged
merged 5 commits into from
Sep 13, 2018
Merged

[DO NOT MERGE] Added list support to VA policies #3878

merged 5 commits into from
Sep 13, 2018

Conversation

t-robalt
Copy link
Contributor

@t-robalt t-robalt commented Sep 12, 2018 •
edited
Loading

Added support to get list of VA policies for servers and managed instance, including databases.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 12, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3594

@t-robalt
Copy link
Contributor Author

@yaakoviyun @yoavfr

jianghaolu
jianghaolu suggested changes Sep 12, 2018
View reviewed changes
...t.Sql/preview/2018-06-01-preview/examples/DatabaseVulnerabilityAssessmentListByDatabase.json Outdated
"serverName": "vulnerabilityaseessmenttest-6440",
"vulnerabilityAssessmentName": "default",
"api-version": "2018-06-01-preview"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required parameter "databaseName".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@t-robalt
Updated database example
e4a5b89
@t-robalt
Changed operation name.
db846d0 
the suffix of "_ListBy..." should be a substring of the operation group, thus changed to Instance.
@jianghaolu jianghaolu merged commit 19800d8 into Azure:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-robalt @AutorestCI @azuresdkci @jianghaolu