-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect url and clarify subscription-level disable (unsure why this came with so many commits) #3886
Conversation
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Can one of the admins verify this patch? |
@sergey-shandar giving it to you, since it seems you have context. |
@asinn826 why are we introducing breaking changes in the stable API? |
Given the invalid URIs that existed in the prior version, I'm assuming this is a case where Swagger deviated from the implementation? If this is simply a case of fixing an invalid swagger spec, signing off from ARM. |
This PR seems to contain all the changes that were approved and merged in this earlier PR: #3498
2 extra changes on top of those are commits ddf58c3 and 90ad551- both minor. Not sure why this is so big. @sergey-shandar , are you able to help me with this one?
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger