Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect url and clarify subscription-level disable (unsure why this came with so many commits) #3886

Merged
merged 33 commits into from
Sep 13, 2018

Conversation

asinn826
Copy link
Contributor

This PR seems to contain all the changes that were approved and merged in this earlier PR: #3498

2 extra changes on top of those are commits ddf58c3 and 90ad551- both minor. Not sure why this is so big. @sergey-shandar , are you able to help me with this one?

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [x ] The title of the PR is clear and informative.
  • [x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [x ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [x ] If applicable, the PR references the bug/issue that it fixes.
  • [x ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3131

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Sep 12, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel
Copy link
Member

lmazuel commented Sep 12, 2018

@sergey-shandar giving it to you, since it seems you have context.

@sergey-shandar
Copy link
Contributor

@asinn826 why are we introducing breaking changes in the stable API?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2018
@KrisBash
Copy link
Contributor

Given the invalid URIs that existed in the prior version, I'm assuming this is a case where Swagger deviated from the implementation? If this is simply a case of fixing an invalid swagger spec, signing off from ARM.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 13, 2018
@sergey-shandar sergey-shandar merged commit b55dc2b into Azure:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants