Modifying app version setting name and Removing region from publish app.

[LanaShafik]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2751

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3362

[AutorestCI]

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

[azuresdkci]

Can one of the admins verify this patch?

[lmazuel]

Hi @LanaShafik
The title of the PR does not match what I see inside. Could you clarify?
Also, you are remving a field, was it here by mistake and never populated? Or did you removed it from the server? Could you give me more context, since this is technically a breaking change that will have to be documented in releases of SDK.
Thank you!

[yangyuan]

So the LUIS app is now cross-region?

[LanaShafik]

Hi @lmazuel

I only changed the "UseNegativeSampling" setting to "UseAllTrainingData".
@mohabghanem will give you more information about the other changes. I will change the PR title to be more convenient.

[mohabghanem]

@lmazuel @yangyuan concerning the change in the region field. Previously, the user used to choose the region they want to publish their app in, so the region field was sent by the publish request. But now when the user issues a publish request, we automatically publish their app to every region they are subscribed to, so the region field is not used anymore.
I know this change is irrelevant to the main purpose of the PR, but I think it is too small to have a PR on its own, so we brought it along.

[lmazuel]

Hi @mohabghanem
I think atomic PR (i.e. one PR for one purpose) is a good habit, and would have been faster here, since I wouldn't had to ask for more context :). There is no such thing as "small PR", since a PR that contains things that are not described in the title just makes me feel someone made a mistake and didn't intended the commit.
Thanks for the additional context! Merging the PR, but that's an important breaking change for SDK: but it's not moving from "required" to "optional", it disappears completely from the method signature. For instance, my Python sample is wrong now.

[AutorestCI]

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js