New resource: Add InGuest resource type software to Compute #4012

abhinav-ghai · 2018-09-26T19:22:45Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-26T19:24:32Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#184

AutorestCI · 2018-09-26T19:24:49Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#3614

AutorestCI · 2018-09-26T19:25:06Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1577

AutorestCI · 2018-09-26T19:30:14Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3019

AutorestCI · 2018-09-26T19:44:19Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2018-09-26T19:47:51Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-26T19:48:16Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3706

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/compute.json

anuchandy · 2018-09-27T19:23:34Z

specification/compute/resource-manager/readme.md

+  - where:
+    - $.definitions.InGuestSoftwareItem
+    suppress:
+    - TrackedResourcePatchOperation


We need to get ARM approval for this suppression, will request for ARM review.

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/compute.json

anuchandy · 2018-09-28T19:41:02Z

@abhinav-gha - Larent @lmazuel noted that we are adding these apis to 2016-04-30-preview and 2018-10-01, but what about other api-versions in the middle 2017-12-01, 2018-06-01? It's weird to see that an operation exist in old API disappears in next couple of api-versions then come back in later one.

ravbhatnagar

Few notes, Please take a look.

ravbhatnagar · 2018-10-02T21:02:05Z

...ification/compute/resource-manager/Microsoft.Compute/preview/2016-04-30-preview/compute.json

@@ -1892,6 +1892,104 @@
        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/guestResourceTypes/software/items":{


lets make the values of guestResourceTypes as an enum and add the allowed values there.

ravbhatnagar · 2018-10-02T21:03:14Z

...ification/compute/resource-manager/Microsoft.Compute/preview/2016-04-30-preview/compute.json

+    },
+    "InGuestSoftwareItemProperties": {
+      "properties": {
+        "name": {


top level property names should not be repeated inside the properties bag. Lets rename this to softwareName

ravbhatnagar · 2018-10-02T21:04:53Z

...ification/compute/resource-manager/Microsoft.Compute/preview/2016-04-30-preview/compute.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/guestResourceTypes/software/items/{itemId}":{


What would GET on /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{vmName}/guestResourceTypes/software return? Do you want to support this API?

anuchandy · 2018-10-08T18:42:43Z

@abhinav-ghai can you address ARM comments and my question on not having this feature in some api-versions?

anuchandy · 2018-10-15T18:12:29Z

Closing the PR to due to inactivity.

Add InGuest resource type software

abf9afc

AutorestCI mentioned this pull request Sep 26, 2018

[AutoPR compute/resource-manager] New resource: Add InGuest resource type software to Compute Azure/azure-sdk-for-go#2832

Closed

Abhinav Ghai added 2 commits September 26, 2018 12:34

Remove guestResourceTypeName parameter

25bfc3f

Remove guestResourceType parameter from get single software

1e90e5f

AutorestCI mentioned this pull request Sep 26, 2018

[AutoPR compute/resource-manager] New resource: Add InGuest resource type software to Compute Azure/azure-sdk-for-node#3706

Closed

azuresdkci assigned anuchandy Sep 26, 2018

azuresdkci requested a review from anuchandy September 26, 2018 19:56

anuchandy requested changes Sep 27, 2018

View reviewed changes

anuchandy added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 27, 2018

anuchandy requested a review from ravbhatnagar September 27, 2018 19:26

Address comments to mark readonly properties

95af767

This was referenced Sep 28, 2018

[AutoPR compute/resource-manager] New resource: Add InGuest resource type software to Compute Azure/azure-sdk-for-python#3457

Closed

[AutoPR compute/resource-manager] New resource: Add InGuest resource type software to Compute Azure/azure-sdk-for-ruby#1708

Closed

ravbhatnagar reviewed Oct 2, 2018

View reviewed changes

ravbhatnagar added the ARMReviewInProgress label Oct 2, 2018

anuchandy closed this Oct 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: Add InGuest resource type software to Compute #4012

New resource: Add InGuest resource type software to Compute #4012

abhinav-ghai commented Sep 26, 2018

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

azuresdkci commented Sep 26, 2018

AutorestCI commented Sep 26, 2018 •

edited

Loading

anuchandy Sep 27, 2018

abhinav-ghai Sep 28, 2018

anuchandy commented Sep 28, 2018

ravbhatnagar left a comment

ravbhatnagar Oct 2, 2018

ravbhatnagar Oct 2, 2018

ravbhatnagar Oct 2, 2018

anuchandy commented Oct 8, 2018

anuchandy commented Oct 15, 2018

New resource: Add InGuest resource type software to Compute #4012

New resource: Add InGuest resource type software to Compute #4012

Conversation

abhinav-ghai commented Sep 26, 2018

PR information

Quality of Swagger

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Sep 26, 2018

AutorestCI commented Sep 26, 2018 • edited Loading

Automation for azure-sdk-for-node

anuchandy Sep 27, 2018

Choose a reason for hiding this comment

abhinav-ghai Sep 28, 2018

Choose a reason for hiding this comment

anuchandy commented Sep 28, 2018

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Oct 2, 2018

Choose a reason for hiding this comment

ravbhatnagar Oct 2, 2018

Choose a reason for hiding this comment

ravbhatnagar Oct 2, 2018

Choose a reason for hiding this comment

anuchandy commented Oct 8, 2018

anuchandy commented Oct 15, 2018

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading

AutorestCI commented Sep 26, 2018 •

edited

Loading