Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the runbook resource schema issues #4017

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix the runbook resource schema issues #4017

merged 1 commit into from
Oct 8, 2018

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Sep 27, 2018

Description

The change is to revert back the incorrect specification added earlier. The fix is now reflective of the service.


This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3125

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3779

@AutorestCI
Copy link

AutorestCI commented Sep 27, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2842

@marstr
Copy link
Member

marstr commented Sep 28, 2018

@vrdmr, mind forwarding me any internal threads where these breaking changes are discussed?

@vrdmr
Copy link
Member Author

vrdmr commented Oct 3, 2018

Hi @marstr - @khughes66 did not copy the correct version of the Runbook and it did not have the changes done in #3420 and #3363. This change only makes the current version of Runbook resource correct.

Please let me know if you need more information. Thanks.

@marstr
Copy link
Member

marstr commented Oct 3, 2018

Ready for me to merge, @vrdmr?

@vrdmr
Copy link
Member Author

vrdmr commented Oct 5, 2018

@marstr Yes Please. Thanks a lot! :)

FYI @khughes66

@marstr marstr merged commit af5ffba into Azure:master Oct 8, 2018
@vrdmr
Copy link
Member Author

vrdmr commented Oct 8, 2018

Thanks @marstr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants