-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the runbook resource schema issues #4017
Conversation
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
@vrdmr, mind forwarding me any internal threads where these breaking changes are discussed? |
Hi @marstr - @khughes66 did not copy the correct version of the Runbook and it did not have the changes done in #3420 and #3363. This change only makes the current version of Runbook resource correct. Please let me know if you need more information. Thanks. |
Ready for me to merge, @vrdmr? |
@marstr Yes Please. Thanks a lot! :) FYI @khughes66 |
Thanks @marstr. |
Description
The change is to revert back the incorrect specification added earlier. The fix is now reflective of the service.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger