Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pipeline Variables / Set Variable Activity / Append Variable Activity #4028

Merged
merged 8 commits into from
Oct 1, 2018
Merged

Add Pipeline Variables / Set Variable Activity / Append Variable Activity #4028

merged 8 commits into from
Oct 1, 2018

Conversation

leonliang33
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI AutorestCI mentioned this pull request Sep 28, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3739

@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

This was referenced Sep 28, 2018
Closed
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2866

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@annatisch
Copy link
Member

Thanks @leonliang33 - these two swagger specs have a large volume of model validation errors - are you able to address some of these?

annatisch
annatisch reviewed Sep 28, 2018
View reviewed changes
Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few minor docs comments.

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated
@@ -3101,6 +3101,39 @@
"message"
]
},
"VariableDefinitionSpecification": {
"description": "Definition of all variables for an Pipeline.",
Copy link
Member

@annatisch annatisch Sep 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a Pipeline"

Additionally - this description says "Definition of all variables - yet it only references a single Specification.
Should it be referencing an array of VariableSpecifications? If not - maybe alter this description.

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated
}
},
"VariableSpecification": {
"description": "Definition of a single variable for an pipeline.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a Pipeline"

@leonliang33
Copy link
Contributor Author

Need more changes @haricr requests

@leonliang33 leonliang33 reopened this Sep 29, 2018
@leonliang33
Copy link
Contributor Author

Reopened, decided no more changes are necessary

This was referenced Sep 29, 2018
Merged
Merged
This was referenced Sep 29, 2018
Merged
Merged
@hvermis
Copy link
Contributor

hvermis commented Sep 29, 2018

@annatisch I will fix the validation errors later. We need to update our capture examples code to get 304-s and most of the errors are about that.

@annatisch annatisch merged commit 9158fcc into Azure:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leonliang33 @AutorestCI @azuresdkci @annatisch @hvermis