Swagger change for Update configuration dynamic group #4165

jemex · 2018-10-11T02:41:41Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-10-11T02:42:40Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#195

AutorestCI · 2018-10-11T02:42:55Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3125

AutorestCI · 2018-10-11T02:45:55Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-10-11T02:46:54Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-10-11T02:50:53Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3876

azuresdkci · 2018-10-11T03:01:48Z

Can one of the admins verify this patch?

marstr

A couple of nits, but otherwise nothing troublesome.

...rce-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json

AutorestCI · 2018-10-12T19:07:31Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#3032

marstr

The descriptions are still filled with grammatical errors and hurried capitalization. However, I cannot force you to appear professional in front of your customers. Please consider spending some real time trying to make this look nice.

marstr · 2018-10-15T19:35:06Z

Are you ready for me to merge, @jemex?

jhendrixMSFT · 2018-10-15T22:57:30Z

@AutorestCI regenerate azure-sdk-for-go

marstr · 2018-10-15T23:07:03Z

Thank you for making those updates, @jemex. I truly appreciate it.

Let me know when you're ready to merge.

marstr · 2018-10-16T00:01:07Z

I got word from @jemex offline that was safe to merge this PR.

jhendrixMSFT · 2018-10-16T15:02:29Z

@AutorestCI regenerate azure-sdk-for-go

* Update property names Update property names - GroupId -> GroupName - DstsName -> AccountName * Update CreateDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update custom-words.txt * Update CreateDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update dstsServiceAccount.json * Update PatchDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update GetDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update dstsServiceAccount.json * Update dstsServiceAccount.json * Update custom-words.txt * Update CreateDstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update dstsServiceAccount.json * Update dstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update GetAllDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update DeleteDstsServiceAccount.json * Update dstsServiceAccount.json * Prettier check * Update dstsServiceAccount.json * Update CreateDstsServiceAccount.json * Update GetAllDstsServiceAccount.json * Update GetDstsServiceAccount.json * Update GetDstsServiceAccountUnderResourceGroup.json * Update PatchDstsServiceAccount.json * Update dstsServiceAccount.json * Update dstsServiceAccount.json * Update dstsServiceAccount.json Co-authored-by: dnangel026 <30422111+dnangel026@users.noreply.github.com>

Swagger change for Update configuration dynamic group

da88a23

AutorestCI mentioned this pull request Oct 11, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-python#3552

Merged

AutorestCI mentioned this pull request Oct 11, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-node#3815

Merged

azuresdkci assigned marstr Oct 11, 2018

azuresdkci requested a review from marstr October 11, 2018 03:04

marstr reviewed Oct 12, 2018

View reviewed changes

...rce-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json Outdated Show resolved Hide resolved

...rce-manager/Microsoft.Automation/preview/2017-05-15-preview/softwareUpdateConfiguration.json Outdated Show resolved Hide resolved

Addressing the feedback and adding the sample examples

fc49169

AutorestCI mentioned this pull request Oct 12, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-js#171

Merged

AutorestCI mentioned this pull request Oct 12, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-go#3000

Closed

marstr approved these changes Oct 15, 2018

View reviewed changes

fixing the capitalization and grammer on the description

0103872

AutorestCI mentioned this pull request Oct 15, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-go#3025

Merged

jemex added 2 commits October 15, 2018 16:41

Changes after reviewing the decriptions

7546ceb

Changes after reviewing the descriptions

915d19e

marstr merged commit bad3cbb into Azure:master Oct 16, 2018

AutorestCI mentioned this pull request Oct 16, 2018

[AutoPR automation/resource-manager] Swagger change for Update configuration dynamic group Azure/azure-sdk-for-go#3031

Merged

jemex mentioned this pull request Oct 23, 2018

[Automation] New SDK for 2018-06-30 changes and other nit fixes Azure/azure-sdk-for-net#4916

Closed

9 tasks

D1v38om83r mentioned this pull request Oct 30, 2018

New SDK for 2018-06-30 changes and other nit fixes ver2 Azure/azure-sdk-for-net#4971

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger change for Update configuration dynamic group #4165

Swagger change for Update configuration dynamic group #4165

jemex commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

azuresdkci commented Oct 11, 2018

marstr left a comment

AutorestCI commented Oct 12, 2018 •

edited

Loading

marstr left a comment •

edited

Loading

marstr commented Oct 15, 2018

jhendrixMSFT commented Oct 15, 2018

marstr commented Oct 15, 2018

marstr commented Oct 16, 2018

jhendrixMSFT commented Oct 16, 2018

Swagger change for Update configuration dynamic group #4165

Swagger change for Update configuration dynamic group #4165

Conversation

jemex commented Oct 11, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Oct 11, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 11, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 11, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Oct 11, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 11, 2018 • edited Loading

Automation for azure-sdk-for-node

azuresdkci commented Oct 11, 2018

marstr left a comment

Choose a reason for hiding this comment

AutorestCI commented Oct 12, 2018 • edited Loading

Automation for azure-sdk-for-go

marstr left a comment • edited Loading

Choose a reason for hiding this comment

marstr commented Oct 15, 2018

jhendrixMSFT commented Oct 15, 2018

marstr commented Oct 15, 2018

marstr commented Oct 16, 2018

jhendrixMSFT commented Oct 16, 2018

jemex commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 11, 2018 •

edited

Loading

AutorestCI commented Oct 12, 2018 •

edited

Loading

marstr left a comment •

edited

Loading