Adding provisionAfterExtensions property for ex… #4306

sirajudeens · 2018-10-22T18:13:02Z

…tension sequencing

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkci · 2018-10-22T18:15:44Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-22T20:03:13Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#630

AutorestCI · 2018-10-22T20:04:02Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3668

AutorestCI · 2018-10-22T20:08:35Z

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4240

AutorestCI · 2018-10-22T20:30:48Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3645

lmazuel · 2018-11-30T23:10:38Z

@AutorestCI rebuild

AutorestCI · 2018-11-30T23:12:43Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1986

AutorestCI · 2018-11-30T23:22:59Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

salameer · 2018-12-06T23:06:49Z

once ARM acks here we can move forward

salameer · 2018-12-06T23:09:59Z

@veronicagg, @lmazuel has already reviewed this one and was waiting for service to go live. once ARM acks please move forward.

KrisBash · 2018-12-07T05:39:05Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

@@ -7067,6 +7067,13 @@
          "readOnly": true,
          "type": "string",
          "description": "The provisioning state, which only appears in the response."
+        },
+        "provisionAfterExtensions": {


Out of curiosity, what is the service behavior if

a VMSS is PUT with provisionAfterExtension, as specified in this version,

a lower-version client does a GET & PUT without provisionAfterExtension specified
Is the property wiped out, is the PUT failed, or is the prior value preserved(merge)? Does the behavior cause undesired effects?

The lower-version client will not receive the property in GET operation, since the property has been introduced in 2018-06-01 onwards.
When there is a PUT operation with out this property, CRP will assume the property value is unmodified. This is the case with any other property.

KrisBash

Signing off for ARM. One comment

veronicagg · 2018-12-07T18:01:22Z

thanks @KrisBash . Merging per @lmazuel previous review.

…ure#4306)

lmazuel self-assigned this Oct 22, 2018

lmazuel self-requested a review October 22, 2018 18:16

lmazuel added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Oct 22, 2018

AutorestCI mentioned this pull request Nov 30, 2018

[AutoPR compute/resource-manager] [Please do not merge] Adding provisionAfterExtensions property for ex… Azure/azure-sdk-for-ruby#1983

Merged

AutorestCI mentioned this pull request Nov 30, 2018

[AutoPR compute/resource-manager] [Please do not merge] Adding provisionAfterExtensions property for ex… Azure/azure-sdk-for-js#627

Merged

Adding provisionAfterExtensions property for extension sequencing

a42c17f

sirajudeens force-pushed the ext-seq branch from 7457755 to a42c17f Compare December 4, 2018 20:22

sirajudeens changed the title ~~[Please do not merge] Adding provisionAfterExtensions property for ex…~~ Adding provisionAfterExtensions property for ex… Dec 4, 2018

salameer added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 5, 2018

salameer unassigned lmazuel Dec 6, 2018

salameer added the Reassign label Dec 6, 2018

azuresdkci assigned lmazuel Dec 6, 2018

salameer assigned veronicagg Dec 6, 2018

KrisBash reviewed Dec 7, 2018

View reviewed changes

KrisBash approved these changes Dec 7, 2018

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 7, 2018

veronicagg merged commit b011d6c into Azure:master Dec 7, 2018

sirajudeens mentioned this pull request Dec 19, 2018

Add provisionAfterExtensions support in CLI Azure/azure-cli#8101

Closed

hyonholee mentioned this pull request Dec 20, 2018

[Compute] Add ProvisionAfterExtensions property to VMSS Azure/azure-sdk-for-net#5104

Merged

9 tasks

aljo-microsoft mentioned this pull request Jan 2, 2019

Question: Azure Service Fabric usage of D drive, while Azure now use it as temporary drive microsoft/service-fabric-issues#1282

Closed

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019

Adding provisionAfterExtensions property for extension sequencing (Az…

bd85951

…ure#4306)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding provisionAfterExtensions property for ex… #4306

Adding provisionAfterExtensions property for ex… #4306

sirajudeens commented Oct 22, 2018 •

edited

Loading

azuresdkci commented Oct 22, 2018

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

lmazuel commented Nov 30, 2018

AutorestCI commented Nov 30, 2018 •

edited

Loading

AutorestCI commented Nov 30, 2018 •

edited

Loading

salameer commented Dec 6, 2018

salameer commented Dec 6, 2018

KrisBash Dec 7, 2018

sirajudeens Dec 7, 2018

KrisBash left a comment

veronicagg commented Dec 7, 2018

Adding provisionAfterExtensions property for ex… #4306

Adding provisionAfterExtensions property for ex… #4306

Conversation

sirajudeens commented Oct 22, 2018 • edited Loading

PR information

Quality of Swagger

azuresdkci commented Oct 22, 2018

AutorestCI commented Oct 22, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 22, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 22, 2018 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Oct 22, 2018 • edited Loading

Automation for azure-sdk-for-go

lmazuel commented Nov 30, 2018

AutorestCI commented Nov 30, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Nov 30, 2018 • edited Loading

Automation for azure-sdk-for-java

salameer commented Dec 6, 2018

salameer commented Dec 6, 2018

KrisBash Dec 7, 2018

Choose a reason for hiding this comment

sirajudeens Dec 7, 2018

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

veronicagg commented Dec 7, 2018

sirajudeens commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading

AutorestCI commented Nov 30, 2018 •

edited

Loading

AutorestCI commented Nov 30, 2018 •

edited

Loading