-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger closure for Azure Migration Hub Operations #4330
Conversation
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-rubyNothing to generate for azure-sdk-for-ruby |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-jsNothing to generate for azure-sdk-for-js |
specification/migrateprojects/resource-manager/readme.nodejs.md
Outdated
Show resolved
Hide resolved
specification/migrateprojects/resource-manager/readme.nodejs.md
Outdated
Show resolved
Hide resolved
Automation for azure-sdk-for-javaNothing to generate for azure-sdk-for-java |
…te/preview/2018-09-01-preview/migrate.json Fixing the JSON schema validation for migrate.json
Fixing the code generation path for preview swagger.
…te/preview/2018-09-01-preview/migrate.json Fixing potential SDK and security errors.
…te/preview/2018-09-01-preview/migrate.json Fixing potential new SDK errors.
@daschult are you satisfied with the changes? |
@azuresdkci add to whitelist |
Pareekshit,
Can you please let us know if this is reverted?
From: Peetambaram Lotla
Sent: Friday, November 9, 2018 10:13 AM
To: Azure/azure-rest-api-specs <reply@reply.github.com>; Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com>; Pareekshit Singh <Pareekshit.Singh@microsoft.com>
Cc: Author <author@noreply.github.com>; Gaurav Bhatnagar <Gaurav.Bhatnagar@microsoft.com>
Subject: RE: [Azure/azure-rest-api-specs] Swagger closure for Azure Migration Hub Operations (#4330)
Hi,
The PR was raised for ARM review. We were not looking forward to merge into master or generate the SDKs for this change as we may have modifications to the swagger based on the review. Can you please revert the merge?
Thanks,
-Peet
From: Pareekshit Singh <notifications@github.com<mailto:notifications@github.com>>
Sent: Friday, November 9, 2018 4:24 AM
To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com<mailto:azure-rest-api-specs@noreply.github.com>>
Cc: Peetambaram Lotla <pelotla@microsoft.com<mailto:pelotla@microsoft.com>>; Author <author@noreply.github.com<mailto:author@noreply.github.com>>
Subject: Re: [Azure/azure-rest-api-specs] Swagger closure for Azure Migration Hub Operations (#4330)
Merged #4330<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2FAzure%2Fazure-rest-api-specs%2Fpull%2F4330&data=02%7C01%7Cpelotla%40microsoft.com%7C5ed14a2fb63d4cd21e5d08d645cd2047%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636773144665096512&sdata=Yjj3cJFG2w8ALQIscDL2D5b%2Fab7okn9tKGR7Q%2FBRX0o%3D&reserved=0> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2FAzure%2Fazure-rest-api-specs%2Fpull%2F4330%23event-1955626776&data=02%7C01%7Cpelotla%40microsoft.com%7C5ed14a2fb63d4cd21e5d08d645cd2047%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636773144665096512&sdata=WVGOZbJW0X34lnkA3JnE2jS5znsmcYJxRbL44vkk1is%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2Fnotifications%2Funsubscribe-auth%2FAd9AQZEtO7V_tWH8GKyYSW55lFiMyi10ks5utLYegaJpZM4X6g2k&data=02%7C01%7Cpelotla%40microsoft.com%7C5ed14a2fb63d4cd21e5d08d645cd2047%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636773144665106516&sdata=%2FFXTPb3%2Fv3sjML14c9P8K2nUtbdeBfwh%2FqxuAGdVp4Q%3D&reserved=0>.
|
* Revert "Add maximum chunk size to data lake store docs. (#4464)" This reverts commit ab9c6ff. * Revert "Add latest authorization tag to java config (#4406)" This reverts commit 7f0fd16. * Revert "Mdb 20181029 statepropdescriptions (#4452)" This reverts commit 90db24c. * Revert "fixing invalid location in examples (#4415)" This reverts commit ffaf595. * Revert "/identity endpoint added (#4460)" This reverts commit 4f93dee. * Revert "Added missing PATCH operation to Api Issue resource (#4440)" This reverts commit 7df0ce5. * Revert "Adds storage account quick failover API (#4457)" This reverts commit 10ec74f. * Revert "DataFactory: add table name in dataset (#4424)" This reverts commit f8465de. * Revert "Update README.md (#4421)" This reverts commit fa6a584. * Revert "Move Ruby SDK config to its own config file (#4451)" This reverts commit 2ca50c8. * Revert "[CognitiveServices] enable Bing Search/CustomSearch products to specify Endpoint (#4401)" This reverts commit dc782b3. * Revert "Add GeoRegion property to DeletedSite model (#4448)" This reverts commit a079367. * Revert " Azure Container Instance: Add start container group API (#4423)" This reverts commit 2ea3e9e. * Revert "add guidance for example names (#4432)" This reverts commit 6780e8a. * Revert "Remove security contact phone field mandatory fields (#4417)" This reverts commit eaf464e. * Revert "Add Allowed Connections REST API (#4106)" This reverts commit 2389da3. * Revert "Make NIC VM readOnly (#4444)" This reverts commit 2d83450. * Revert "Remove readonly attribute from identities collection in users (#4442)" This reverts commit 7577df9. * Revert "Add spec for alert repair/remediate (#4084)" This reverts commit 3f568b4. * Revert "Py conf in its own file (#4439)" This reverts commit 3373760. * Revert "Split Python conf in it's own file (#4438)" This reverts commit 77cf607. * Revert "Adding ManagedInstanceVulnerabilityAssessments and ServerVulnerabilityAssessments (#4416)" This reverts commit dec7549. * Revert "WebApps: Snapshots API for DR stamps (#4291)" This reverts commit 916ff2e. * Revert "Swagger closure for Azure Migration Hub Operations (#4330)" This reverts commit badd1de.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger