Add 201 response to AppServicePlans_CreateOrUpdate #4351

pietro · 2018-10-29T21:00:50Z

azuresdkci · 2018-10-29T21:05:28Z

Can one of the admins verify this patch?

AutorestCI · 2018-10-29T21:05:37Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_web/resource-manager
  stderr: 'remote: Permission to Azure/azure-sdk-for-js.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-js.git/': The requested URL returned error: 403'

AutorestCI · 2018-10-29T21:06:49Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2184

AutorestCI · 2018-10-29T21:13:28Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4155

AutorestCI · 2018-10-29T21:14:08Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#4429

AutorestCI · 2018-10-29T21:54:27Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_web/resource-manager
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

AutorestCI · 2018-10-29T22:12:56Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4757

annatisch · 2018-10-31T15:15:20Z

Thanks for the fix @pietro!
The changes look good - however there are quite a few model validation errors for these two specs. Most of them are unrelated to your changes - however it would be great if you could fix up the errors related to the two samples you've updated (these 3 errors apply to the same sample in both API versions):

error : 
operationId: AppServicePlans_CreateOrUpdate
scenario: Create or Update App Service plan
source: response
responseCode: '200'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - mdmId
      - currentNumberOfWorkers
      - currentWorkerSize
      - numberOfWorkers
      - workerSize
  message: >-
    Additional properties not allowed:
    mdmId,currentNumberOfWorkers,currentWorkerSize,numberOfWorkers,workerSize
  path: properties
  jsonUrl: >-
    specification/web/resource-manager/Microsoft.Web/stable/2016-09-01/examples/CreateOrUpdateAppServicePlan.json

error : 
operationId: AppServicePlans_CreateOrUpdate
scenario: Create or Update App Service plan
source: response
responseCode: '201'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - mdmId
      - currentNumberOfWorkers
      - currentWorkerSize
      - numberOfWorkers
      - workerSize
  message: >-
    Additional properties not allowed:
    mdmId,currentNumberOfWorkers,currentWorkerSize,numberOfWorkers,workerSize
  path: properties
  jsonUrl: >-
    specification/web/resource-manager/Microsoft.Web/stable/2016-09-01/examples/CreateOrUpdateAppServicePlan.json

 error : 
operationId: AppServicePlans_CreateOrUpdate
scenario: Create or Update App Service plan
source: response
responseCode: '202'
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - mdmId
      - currentNumberOfWorkers
      - currentWorkerSize
      - numberOfWorkers
      - workerSize
  message: >-
    Additional properties not allowed:
    mdmId,currentNumberOfWorkers,currentWorkerSize,numberOfWorkers,workerSize
  path: properties
  jsonUrl: >-
    specification/web/resource-manager/Microsoft.Web/stable/2016-09-01/examples/CreateOrUpdateAppServicePlan.json

If you felt like knocking out any of the other remaining example validation errors that would be bonus brownie points ;)
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/448024117

pietro · 2018-10-31T16:44:15Z

@annatisch Thanks for the review. I'll look into the errors and I'll try to update the models to match the examples.

annatisch · 2018-10-31T17:36:35Z

Thanks @pietro - but please confirm whether it's the models or the examples that need to be updated.

pietro · 2018-10-31T22:51:50Z

@annatisch the models need to be updated. I'm adding the properties and their types, but I'm skipping the description.

annatisch · 2018-11-01T15:25:26Z

@pietro - Please do not skip the description - even if it is simplistic for now. These descriptions are used to generate the API documentation for docs.microsoft.com and leaving them blank is confusing for customers.

Additionally - I see you are not yet a member of the Azure GitHub org - can you please join?

pietro · 2018-11-01T16:31:19Z

Please do not skip the description - even if it is simplistic for now

I'll add them soon.

I see you are not yet a member of the Azure GitHub org - can you please join?

Sure, can you send me the invite?

annatisch · 2018-11-01T16:50:04Z

Thanks @pietro - please join through aka.ms/azuregithub :)

pietro · 2018-11-01T17:42:25Z

@annatisch I tried to join but I got this error:

Selected user account does not exist in tenant 'Microsoft' and cannot access the application 'SOME_UUID' in that tenant. The account needs to be added as an external user in the tenant first. Please use a different account.

Maybe I can't join because I'm not a MSFT employee?

annatisch · 2018-11-01T18:39:04Z

Ah - sorry @pietro - I assumed you were with MSFT.
In that case I will need to bring in the service team to validate these PR changes.

amarzavery · 2018-12-04T12:45:55Z

@naveedaz - Can you please review the changes in the PR? They are from an external contributor.

sarangan12 · 2019-01-09T21:28:23Z

@naveedaz - Can you please review the changes in the PR? They are from an external contributor.

sarangan12 · 2019-01-15T19:52:05Z

@naveedaz - Can you please review the changes in the PR? They are from an external contributor.

naveedaz · 2018-11-13T20:57:57Z

specification/web/resource-manager/Microsoft.Web/stable/2016-03-01/CommonDefinitions.json

@@ -371,6 +371,32 @@
        "name": "ProvisioningState",
        "modelAsString": false
       }
+      },


Even though these show up on the wire, they are legacy properties and need to be excluded from swagger. API clients should not depend on these properties. The validations fail currently and we are working with the Azure SDK team to suppress these validation errors. Instead please remove them from the examples.

naveedaz · 2018-11-13T20:59:01Z

specification/web/resource-manager/Microsoft.Web/stable/2018-02-01/CommonDefinitions.json

@@ -410,6 +410,32 @@
                "name": "ProvisioningState",
                "modelAsString": false
              }
+            },


Even though these show up on the wire, they are legacy properties and need to be excluded from swagger. API clients should not depend on these properties. The validations fail currently and we are working with the Azure SDK team to suppress these validation errors. Instead please remove them from the examples.

Fixes Azure#3648.

pietro · 2019-01-17T18:55:49Z

@naveedaz I removed the commits that added the legacy properties.

sarangan12 · 2019-02-22T18:26:53Z

@naveedaz What is the plan for this PR? Are you planning to approve this?

azuresdkci assigned annatisch Oct 29, 2018

azuresdkci requested a review from annatisch October 29, 2018 21:01

AutorestCI mentioned this pull request Oct 29, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-js#351

Closed

AutorestCI mentioned this pull request Oct 29, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-ruby#1832

Closed

AutorestCI mentioned this pull request Oct 29, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-go#3168

Closed

AutorestCI mentioned this pull request Oct 29, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-python#3713

Closed

This was referenced Oct 29, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-java#2543

Closed

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-node#3982

Closed

pietro force-pushed the github_3648 branch from ae05595 to 99c5161 Compare October 31, 2018 22:58

AutorestCI mentioned this pull request Oct 31, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-js#370

Closed

pietro force-pushed the github_3648 branch 4 times, most recently from 3b520fc to 422b947 Compare November 1, 2018 00:29

AutorestCI mentioned this pull request Nov 7, 2018

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-js#435

Closed

annatisch added the Reassign label Nov 28, 2018

azuresdkci removed the Reassign label Nov 28, 2018

azuresdkci assigned amarzavery and unassigned annatisch Nov 28, 2018

azuresdkci requested a review from amarzavery November 28, 2018 19:07

annatisch removed their request for review November 28, 2018 20:12

amarzavery assigned sarangan12 and unassigned amarzavery Jan 2, 2019

sarangan12 requested a review from naveedaz January 2, 2019 19:19

sarangan12 assigned naveedaz Jan 2, 2019

naveedaz reviewed Jan 16, 2019

View reviewed changes

pietro added 2 commits January 17, 2019 10:49

Add 201 response to AppServicePlans_CreateOrUpdate.

f13c7e5

Fixes Azure#3648.

Add examples of 201 response to AppServicePlans_CreateOrUpdate.

b358cc2

pietro force-pushed the github_3648 branch from 723d071 to b358cc2 Compare January 17, 2019 18:52

AutorestCI mentioned this pull request Jan 17, 2019

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-ruby#2158

Merged

This was referenced Jan 17, 2019

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-js#943

Closed

[AutoPR web/resource-manager] Add 201 response to AppServicePlans_CreateOrUpdate Azure/azure-sdk-for-go#3897

Closed

naveedaz approved these changes Feb 22, 2019

View reviewed changes

sarangan12 approved these changes Feb 26, 2019

View reviewed changes

sarangan12 merged commit 81cd2dd into Azure:master Feb 26, 2019

pietro deleted the github_3648 branch March 1, 2019 21:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 201 response to AppServicePlans_CreateOrUpdate #4351

Add 201 response to AppServicePlans_CreateOrUpdate #4351

pietro commented Oct 29, 2018

azuresdkci commented Oct 29, 2018

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

annatisch commented Oct 31, 2018

pietro commented Oct 31, 2018

annatisch commented Oct 31, 2018

pietro commented Oct 31, 2018

annatisch commented Nov 1, 2018

pietro commented Nov 1, 2018

annatisch commented Nov 1, 2018

pietro commented Nov 1, 2018

annatisch commented Nov 1, 2018

amarzavery commented Dec 4, 2018

sarangan12 commented Jan 9, 2019

sarangan12 commented Jan 15, 2019

naveedaz Nov 13, 2018

naveedaz Nov 13, 2018

pietro commented Jan 17, 2019

sarangan12 commented Feb 22, 2019

Add 201 response to AppServicePlans_CreateOrUpdate #4351

Add 201 response to AppServicePlans_CreateOrUpdate #4351

Conversation

pietro commented Oct 29, 2018

azuresdkci commented Oct 29, 2018

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Oct 29, 2018 • edited Loading

Automation for azure-sdk-for-node

annatisch commented Oct 31, 2018

pietro commented Oct 31, 2018

annatisch commented Oct 31, 2018

pietro commented Oct 31, 2018

annatisch commented Nov 1, 2018

pietro commented Nov 1, 2018

annatisch commented Nov 1, 2018

pietro commented Nov 1, 2018

annatisch commented Nov 1, 2018

amarzavery commented Dec 4, 2018

sarangan12 commented Jan 9, 2019

sarangan12 commented Jan 15, 2019

naveedaz Nov 13, 2018

Choose a reason for hiding this comment

naveedaz Nov 13, 2018

Choose a reason for hiding this comment

pietro commented Jan 17, 2019

sarangan12 commented Feb 22, 2019

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading

AutorestCI commented Oct 29, 2018 •

edited

Loading