Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameter to keep order in SDK #4376

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

EvgenyAgafonchikov
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#378

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1798

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3617

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: dep ensure
Finished with return code 1
and output:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export golang.org/x/net: failed to fetch source for https://go.googlesource.com/net: unable to get repository: Cloning into '/tmp/tmpkkdnsxq2/pkg/dep/sources/https---go.googlesource.com-net'...
fatal: unable to access 'https://go.googlesource.com/net/': The requested URL returned error: 502
: command failed: [git clone --recursive -v --progress https://go.googlesource.com/net /tmp/tmpkkdnsxq2/pkg/dep/sources/https---go.googlesource.com-net]: exit status 128

@AutorestCI
Copy link

AutorestCI commented Nov 1, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4003

Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge ASAP

@lmazuel lmazuel merged commit 018cd1a into Azure:master Nov 1, 2018
@EvgenyAgafonchikov EvgenyAgafonchikov deleted the fix-order branch May 15, 2019 07:18
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* add error message

* Add hilo new version 2021-09-15-preview

* Revert "Add hilo new version 2021-09-15-preview"

This reverts commit 5bbedbebb8d606dcf2b9d240668764876f4107fd.

Co-authored-by: Fan Sun <sunfan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants