New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Swagger specification for Microsoft.SqlVirtualMachine Resource Provider. #4385

Merged

sergey-shandar merged 6 commits into Azure:master from yareyes:yadi-restapiswagger

Nov 16, 2018

Member

yareyes commented Nov 2, 2018

The SQL IaaS Team is adding a new Resource Provider. This Swagger contains all the restful operations that can be performed by the customers.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- [x ] The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

yareyes added 2 commits

November 1, 2018 15:40


          Adding new SQL VM Resource Manager swagger and examples

9c89948


          Final swagger

ccb25f2

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3810

azuresdkci assigned jhendrixMSFT

azuresdkci requested a review from jhendrixMSFT

November 2, 2018 01:06

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

Member Author

yareyes commented Nov 2, 2018

Adding @jaredmoo.

AutorestCI commented Nov 2, 2018 •

edited

Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

Contributor

azuresdkci commented Nov 2, 2018

Can one of the admins verify this patch?

Contributor

jaredmoo commented Nov 2, 2018

You will need a readme.md. I can help you with this.

jaredmoo suggested changes

View reviewed changes

Contributor

jaredmoo left a comment

I am being critical of some naming & description, but you have done an awesome job here so far!

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

Member Author

yareyes commented Nov 2, 2018

@seliu is added to the review. #Closed


          Addressing code review comments, adding readme file

5e8b280

AutorestCI mentioned this pull request

[AutoPR sqlvirtualmachine/resource-manager] [Do Not Merge] New Swagger specification for Microsoft.SqlVirtualMachine Resource Provider. Azure/azure-sdk-for-python#3748

Merged

yareyes changed the title ~~[Do Not Merge] New Swagger specification for Microsoft.SqlVirtualMachine Resource Provider.~~ New Swagger specification for Microsoft.SqlVirtualMachine Resource Provider.

jaredmoo suggested changes

View reviewed changes

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated

+                        "readOnly": true
+                      },
+                      "resource": {
+                        "description": "The localized friendly form of the resource type related to this action/operation.",

Contributor

jaredmoo Nov 6, 2018

Also "conectivity" is a typo

yareyes added 2 commits

November 13, 2018 18:43


          Addressing code review comments

94c6782


          Addressing code review comments

f282072

jaredmoo approved these changes

View reviewed changes

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json

+                    "type": "object",
+                    "properties": {
+                      "name": {
+                        "description": "The

Contributor

jaredmoo Nov 15, 2018

Are these passwords non-readable, i.e. mutability = create,update ?

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json Outdated Show resolved Hide resolved

salameer added WaitForARMFeedback Reassign labels

salameer unassigned jhendrixMSFT

azuresdkci removed the Reassign label

azuresdkci assigned sergey-shandar

azuresdkci requested a review from sergey-shandar

November 15, 2018 22:03

Contributor

sergey-shandar commented Nov 16, 2018 •

edited

Loading

@yareyes could you address questions/comments from @jaredmoo ?


          Addressing comments

5fb1ee8

Member Author

yareyes commented Nov 16, 2018

@sergey-shandar comments have been addressed.

Contributor

jaredmoo commented Nov 16, 2018

The description updates are great, thanks!

sergey-shandar approved these changes

View reviewed changes

sergey-shandar merged commit 19e68db into Azure:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WaitForARMFeedback