Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network wathcer] add a new field trafficAnalyticsInterval for TA #4420

Merged
merged 7 commits into from
Nov 7, 2018
Merged

[Network wathcer] add a new field trafficAnalyticsInterval for TA #4420

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4f438a
Update specification/network/resource-manager/Microsoft.Network/stabl…
zwswim Nov 1, 2018
2c9be47
Revert "Update specification/network/resource-manager/Microsoft.Netwo…
zwswim Nov 1, 2018
90b4c89
Update specification/network/resource-manager/Microsoft.Network/stabl…
zwswim Nov 1, 2018
0d9f657
Update specification/network/resource-manager/Microsoft.Network/stabl…
zwswim Nov 7, 2018
af9e218
Revert "Update specification/network/resource-manager/Microsoft.Netwo…
zwswim Nov 7, 2018
092763a
Revert "Revert "Update specification/network/resource-manager/Microso…
zwswim Nov 7, 2018
1620961
Revert "Update specification/network/resource-manager/Microsoft.Netwo…
zwswim Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...fication/network/resource-manager/Microsoft.Network/stable/2018-10-01/networkWatcher.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2669,7 +2669,11 @@
},
"workspaceResourceId": {
"description": "Resource Id of the attached workspace ",
"type": "string"
"type": "string"
},
"trafficAnalyticsInterval": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of the examples need to be updated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the optional field. I am new for swagger. Could you let know what do you means examples ?

        Do any of the examples need to be updated?

This is the optional field. I am new for swagger. Could you let know what do you means examples ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's an optional field this should not be an issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        If it's an optional field this should not be an issue.

Hi, Thanks for take care of the review. Do I need to do anything like click the button "close Pull Request" after you approve the PR ?

"description": "The interval in minutes which would decide how frequently TA service should do flow analytics",
"type": "integer"
}
}
},
Expand Down