Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type for DeploymentExtend and ResourceGroup #4501

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Add type for DeploymentExtend and ResourceGroup #4501

merged 1 commit into from
Nov 26, 2018

Conversation

zjpjack
Copy link
Contributor

@zjpjack zjpjack commented Nov 19, 2018

We add Type in ARM API, accordingly we also add Type for DeploymentExtended and ResourceGroup for consistency

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#504

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3187

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4192

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3401

@AutorestCI
Copy link

AutorestCI commented Nov 19, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

"readOnly": true,
"type": "string",
"description": "The type of the deployment."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the property recently added or was it simply missed while creating the swagger initially.

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 22, 2018
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 26, 2018
@sarangan12 sarangan12 merged commit f1e5660 into Azure:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants