fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments #4508

nschonni · 2018-11-20T02:51:06Z

diagnosics -> diagnostics [BREAKING CHANGE]
Availabilily -> Availability [BREAKING CHANGE]
enviroment -> environment

I can split out the "environment" fix since that is a typo. Not sure how to handle the 2 breaking changes, should they be submitted separately and only to the latest API JSON file?

- diagnosics -> diagnostics [BREAKING CHANGE] - Availabilily -> Availability [BREAKING CHANGE] - enviroment -> environment

openapi-portal-comment · 2018-11-20T02:51:08Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-11-20T02:51:43Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

AutorestCI · 2018-11-20T02:51:47Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

AutorestCI · 2018-11-20T02:51:56Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

AutorestCI · 2018-11-20T02:52:36Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

AutorestCI · 2018-11-20T02:53:24Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

azuresdkci · 2018-11-20T02:55:31Z

Can one of the admins verify this patch?

AutorestCI · 2018-11-20T03:06:52Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 8b27fe397948cc61bab55b5a670c77c9c01b136e
  stderr: 'fatal: reference is not a tree: 8b27fe397948cc61bab55b5a670c77c9c01b136e'

amarzavery · 2018-11-20T21:13:18Z

@nschonni -

I can split out the "environment" fix since that is a typo. Not sure how to handle the 2 breaking changes, should they be submitted separately and only to the latest API JSON file?

Will the fix be applied to all the previous api versions? If so then their swagger specs should also be fixed. This will have a direct impact on Azure Stack since they are mostly several api versions behind.
@veronicagg , @salameer - What would be your recommendation on this issue?

amarzavery · 2018-11-20T21:49:43Z

specification/web/resource-manager/Microsoft.Web/stable/2016-09-01/AppServiceEnvironments.json

@@ -1924,13 +1924,13 @@
          "description": "Name/identifier of the diagnostics.",
          "type": "string"
        },
-        "diagnosicsOutput": {
+        "diagnosticsOutput": {


@nschonni - Any reason to make a breaking change in an already deployed api-version? Have you already deployed this change? This will make it increasingly difficult for customers to using Azure stack. I would expect you to not touch the old api version and make a breaking change in the new api version (which is the definition of a breaking change).

What happens if customers would send a request with old property names for api version 2016-09-01? Does the service alias both the property names on it's side?

No idea how the previous versions work or if there is a redirect functionality available in the API to forward the requests to the other endpoint. I think I'm going to move the "environment" fix to a separate PR since that part is straight forward.

@naveedaz - Can you take a look at this?

@nschonni What is the motivation to change the names of the properties? It is unfortunate that the property names have spelling issues but we cannot simply change it in the swagger file because the service will still send them with the misspelled names and then these properties will not be deserialized on the client end at all.

Fixing typo stuff on the documentation that lead me up to this repo through the sdk ones.
If you want to file bugs to fix this in the next version, that's fine with me.

amarzavery · 2018-11-21T23:46:29Z

Closing this PR for now. @naveedaz - Please take a look in fixing typos of property names if possible in the future api versions.

fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments

2b3a5f1

- diagnosics -> diagnostics [BREAKING CHANGE] - Availabilily -> Availability [BREAKING CHANGE] - enviroment -> environment

nschonni requested a review from naveedaz as a code owner November 20, 2018 02:51

azuresdkci assigned amarzavery Nov 20, 2018

azuresdkci requested a review from amarzavery November 20, 2018 02:51

AutorestCI mentioned this pull request Nov 20, 2018

[AutoPR web/resource-manager] fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments Azure/azure-sdk-for-ruby#1929

Closed

amarzavery reviewed Nov 20, 2018

View reviewed changes

nschonni mentioned this pull request Nov 21, 2018

typo: web/resource-manager/Microsoft.Web/AppServiceEnvironments #4527

Merged

amarzavery closed this Nov 21, 2018

nschonni deleted the typo-web/resource-manager/Microsoft.Web/AppServiceEnvironments.json branch November 22, 2018 00:25

billytrend mentioned this pull request Nov 27, 2018

Adds encoding to url parameters veronicagg/openapi-portal-comment#6

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments #4508

fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments #4508

nschonni commented Nov 20, 2018

openapi-portal-comment bot commented Nov 20, 2018

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

azuresdkci commented Nov 20, 2018

AutorestCI commented Nov 20, 2018 •

edited

Loading

amarzavery commented Nov 20, 2018

amarzavery Nov 20, 2018

amarzavery Nov 20, 2018

nschonni Nov 20, 2018

amarzavery Nov 21, 2018

naveedaz Nov 21, 2018

nschonni Nov 21, 2018

amarzavery commented Nov 21, 2018

fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments #4508

fix(breaking): web/resource-manager/Microsoft.Web/AppServiceEnvironments #4508

Conversation

nschonni commented Nov 20, 2018

openapi-portal-comment bot commented Nov 20, 2018

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Nov 20, 2018

AutorestCI commented Nov 20, 2018 • edited Loading

Automation for azure-sdk-for-node

amarzavery commented Nov 20, 2018

amarzavery Nov 20, 2018

Choose a reason for hiding this comment

amarzavery Nov 20, 2018

Choose a reason for hiding this comment

nschonni Nov 20, 2018

Choose a reason for hiding this comment

amarzavery Nov 21, 2018

Choose a reason for hiding this comment

naveedaz Nov 21, 2018

Choose a reason for hiding this comment

nschonni Nov 21, 2018

Choose a reason for hiding this comment

amarzavery commented Nov 21, 2018

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading

AutorestCI commented Nov 20, 2018 •

edited

Loading