Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetApp RP minor update and validation fixes #4520

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Conversation

leonardbf
Copy link
Contributor

Removed obsolete Mount Target Delete operation.
Fixed autorest pagination warnings.
(NetApp ticket NFSAAS-1505)

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3203

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented Nov 20, 2018

Couple of warnings - removing an operation and marking return values as paginated will be a breaking change in strongly typed languages however since the swagger is in preview folder we do not block merge. Please confirm that it is ok for you to break customers code.

@leonardbf
Copy link
Contributor Author

Couple of warnings - removing an operation and marking return values as paginated will be a breaking change in strongly typed languages however since the swagger is in preview folder we do not block merge. Please confirm that it is ok for you to break customers code.

Yes, the removal of the operation is ok and is because it is no longer present in the application.
The pagination (forcing null) was added because without this block the autorest validation was producing warnings, e.g. Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension

@hovsepm hovsepm merged commit 5a020ec into Azure:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants