Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API #4724

Merged
merged 3 commits into from
Dec 11, 2018
Merged

[Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API #4724

merged 3 commits into from
Dec 11, 2018

Conversation

meiyan-Li
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3644

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@AutorestCI AutorestCI mentioned this pull request Dec 3, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 3, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@meiyan-Li
Copy link
Contributor Author

@hvermis Please help take a look, thanks!

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 3, 2018
@meiyan-Li meiyan-Li changed the title Adding refresh and get IntegrationRuntimeObjectMetadata API [Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectMetadata API Dec 6, 2018
KrisBash
KrisBash approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ARM

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 6, 2018
hvermis
hvermis reviewed Dec 7, 2018
View reviewed changes
...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated
"$ref": "./examples/IntegrationRuntimeObjectMetadata_Refresh.json"
}
},
"description": "Refresh a ssis integration runtime object metadata.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "SSIS"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

hvermis
hvermis reviewed Dec 7, 2018
View reviewed changes
...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json Outdated
"$ref": "./examples/IntegrationRuntimeObjectMetadata_Get.json"
}
},
"description": "Get a ssis integration runtime object metadata by specified path. The return is pageable metadata list.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, and any other if there are more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update

@meiyan-Li
Copy link
Contributor Author

@sergey-shandar Could you help merge the code?

@sergey-shandar
Copy link
Contributor

@meiyan-Li could you fix model validation errors?

@azuresdkci azuresdkci requested a review from amarzavery December 7, 2018 23:03
@amarzavery
Copy link
Contributor

@meiyan-Li There are model validation failures. Please fix them. You can take a look at the logs over here.

amarzavery
amarzavery suggested changes Dec 8, 2018
View reviewed changes
Copy link
Contributor

@amarzavery amarzavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix model validation failures.

@meiyan-Li
Copy link
Contributor Author

@amarzavery I have fixed my model validation issue. For the existing operation model validation issue, hermins have a backlog to fix it. Please see this PR for more info: #3957

@meiyan-Li
Copy link
Contributor Author

@amarzavery Please help merge this PR

@amarzavery amarzavery merged commit 026fdc7 into Azure:master Dec 11, 2018
@meiyan-Li meiyan-Li mentioned this pull request Jan 15, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@meiyan-Li @AnuTalluri
[Azure Data Factory] Adding refresh and get IntegrationRuntimeObjectM…
ae5c3bf 
…etadata API (Azure#4724)

* Adding refresh and get IntegrationRuntimeObjectMetadata API

* Change ssis to upper case

* Fix model validation issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvermis hvermis hvermis approved these changes

@KrisBash KrisBash KrisBash approved these changes

@amarzavery amarzavery amarzavery approved these changes

@sergey-shandar sergey-shandar Awaiting requested review from sergey-shandar

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@meiyan-Li @AutorestCI @azuresdkci @sergey-shandar @amarzavery @KrisBash @hvermis