Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor delete activity payload #4747

Merged
merged 6 commits into from
Dec 6, 2018
Merged

Refactor delete activity payload #4747

merged 6 commits into from
Dec 6, 2018

Conversation

yuzhangyi
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3604

@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4190

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from sarangan12 December 4, 2018 03:27
@AutorestCI AutorestCI mentioned this pull request Dec 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Dec 4, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#578

@yuzhangyi
Copy link
Contributor Author

yuzhangyi commented Dec 6, 2018 •
edited
Loading

Hi, @sarangan12, can you help finish this change review and merge it into master? Now we wait for newest SDK based on this change, thanks!

@sarangan12 sarangan12 merged commit 8e9ff04 into Azure:master Dec 6, 2018
@meiyan-Li meiyan-Li mentioned this pull request Jan 15, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@yuzhangyi @AnuTalluri
Refactor delete activity payload (Azure#4747)
aa3518b 
* Enable delete activity

* Enable delete activity.

* Update

* Refactor delete activity content

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarangan12 sarangan12 sarangan12 approved these changes

Assignees

@sarangan12 sarangan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuzhangyi @AutorestCI @azuresdkci @sarangan12 @zhanyu2024