Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add three new APIs to microsoft.resourcehealth #4796

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Add three new APIs to microsoft.resourcehealth #4796

merged 4 commits into from
Dec 11, 2018

Conversation

wengjn
Copy link
Contributor

@wengjn wengjn commented Dec 5, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#800

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3690

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from praries880 December 5, 2018 19:51
@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4419

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Jeff Weng added 2 commits December 5, 2018 12:06
fix the schema for new apis
4877939 
reuse the old schema instead of creating new ones
fix schema another error
312b487
This was referenced Dec 5, 2018
Merged
Merged
Merged
@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 6, 2018
KrisBash
KrisBash suggested changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed from ARM

@KrisBash KrisBash added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Dec 7, 2018
@KrisBash
Copy link
Contributor

KrisBash commented Dec 7, 2018

@wengjn feel free to set up a meeting with ARM API review if you'd like to discuss.

@ravbhatnagar
Copy link
Contributor

@wengjn - please let us know when this is ready for re-review by ARM or feel free to set up a meeting.

Change resource type name as suggested from ARM review
280360e 
Change resource type name as suggested from ARM review: childAvailabilityStatuses and childResources
@wengjn
Copy link
Contributor Author

wengjn commented Dec 11, 2018

This is updated. All comments have been resolved. Thx

KrisBash
KrisBash approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changes. Thanks

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 11, 2018
@praries880 praries880 merged commit bdb2d95 into Azure:master Dec 11, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@wengjn @AnuTalluri
Add three new APIs to microsoft.resourcehealth (Azure#4796)
1bfee4a 
* Add three new APIs to microsoft.resourcehealth

* fix the schema for new apis

reuse the old schema instead of creating new ones

* fix schema another error

* Change resource type name as suggested from ARM review

Change resource type name as suggested from ARM review: childAvailabilityStatuses and childResources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praries880 praries880 praries880 approved these changes

@KrisBash KrisBash KrisBash approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wengjn @AutorestCI @azuresdkci @KrisBash @ravbhatnagar @praries880