Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACR] Add Helm actions to webhook #4820

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

jaysterp
Copy link
Member

@jaysterp jaysterp commented Dec 6, 2018

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4052

@jaysterp
Copy link
Member Author

jaysterp commented Dec 6, 2018

//cc @djyou @sajayantony

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#623

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1980

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node
EDIT: Azure/azure-sdk-for-node#4232

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Dec 6, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2460

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jaysterp
Copy link
Member Author

//cc @djyou @sajayantony

@jhendrixMSFT jhendrixMSFT removed their request for review December 11, 2018 22:22
@hovsepm
Copy link
Contributor

hovsepm commented Dec 13, 2018

@AutorestCI retest this please

@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

4 similar comments
@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@AutorestCI
Copy link

I didn't understand your command:

retest this please

in this context, sorry :(
This is what I can do:

  • rebuild
  • regenerate
  • help : this help message

@hovsepm
Copy link
Contributor

hovsepm commented Dec 13, 2018

@AutorestCI rebuild

@openapi-portal-comment
Copy link

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

Encountered a Subprocess error

Command: go generate ./profiles/generate.go
Finished with return code 1
and output:

[STATUS] Output-Location set to: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/network/mgmt/network/networkapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/storage/mgmt/storage/storageapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/mgmt/keyvault/keyvaultapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/compute/mgmt/compute/computeapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/storage/mgmt/storage/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/subscriptions/subscriptionsapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/keyvault/keyvaultapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/subscriptions/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/locks/locksapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/resources/resourcesapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/links/linksapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/policy/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/links/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/features/featuresapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/locks/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/compute/mgmt/compute/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/features/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/resources/mgmt/resources/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/mgmt/keyvault/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/keyvault/keyvault/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2017-03-09/network/mgmt/network/models.go
[STATUS] 21 packages generated.
[STATUS] Output-Location set to: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/web/mgmt/web/webapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/policy/policyapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/authorization/mgmt/authorization/authorizationapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/keyvault/keyvault/keyvaultapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/links/linksapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/keyvault/mgmt/keyvault/keyvaultapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/locks/locksapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/authorization/mgmt/authorization/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/network/mgmt/network/networkapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/keyvault/mgmt/keyvault/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/dns/mgmt/dns/dnsapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/policy/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/compute/mgmt/compute/computeapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/storage/mgmt/storage/storageapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/resources/resourcesapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/locks/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/subscriptions/subscriptionsapi/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/links/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/storage/mgmt/storage/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/subscriptions/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/resources/mgmt/resources/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/keyvault/keyvault/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/dns/mgmt/dns/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/compute/mgmt/compute/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/network/mgmt/network/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/2018-03-01/web/mgmt/web/models.go
[STATUS] 26 packages generated.
[STATUS] Output-Location set to: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/computervision/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/appinsights/insights/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/textanalytics/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/search/mgmt/search/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/machinelearning/mgmt/webservices/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/domainservices/mgmt/aad/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/luis/runtime/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/operationalinsights/operationalinsights/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resourcehealth/mgmt/resourcehealth/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/spellcheck/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datacatalog/mgmt/datacatalog/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/links/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/marketplaceordering/mgmt/marketplaceordering/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/locks/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/authorization/mgmt/authorization/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/subscriptions/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/features/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/keyvault/mgmt/keyvault/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/videosearch/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/powerbidedicated/mgmt/powerbidedicated/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/powerbiembedded/mgmt/powerbiembedded/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/advisor/mgmt/advisor/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/cognitiveservices/customsearch/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/resources/mgmt/policy/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/containerservice/mgmt/containerservice/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/mediaservices/mgmt/media/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/datalake/store/filesystem/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/eventgrid/eventgrid/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/dns/mgmt/dns/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/azsadmin/mgmt/infrastructureinsights/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/containerregistry/mgmt/containerregistry/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/operationalinsights/mgmt/operationalinsights/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/storageimportexport/mgmt/storageimportexport/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/provisioningservices/mgmt/iothub/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/scheduler/mgmt/scheduler/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/analysisservices/mgmt/analysisservices/models.go
[STATUS] Writing File: /tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/trafficmanager/mgmt/trafficmanager/models.go
[ERROR] error formatting profile '/tmp/tmpm9k1n_c3/src/github.com/Azure/azure-sdk-for-go/profiles/latest/machinelearning/mgmt/webservices/models.go': exit status 2
exit status 1
latest/generate.go:17: running "go": exit status 1
profiles/generate.go:19: running "go": exit status 1

@hovsepm hovsepm merged commit d9949f3 into Azure:master Dec 14, 2018
@kpajdzik kpajdzik removed the review label Dec 14, 2018
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants